feat: Add option to include no shows in RR calculations #21063

joeauyeung · 2025-05-01T18:07:54Z

What does this PR do?

Fixes #XXXX (GitHub issue number)
Fixes CAL-XXXX (Linear issue number - should be visible at the bottom of the GitHub issue description)

Visual Demo (For contributors especially)

A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).

Video Demo (if applicable):

Show screen recordings of the issue or feature.
Demonstrate how to reproduce the issue, the behavior before and after the change.

Image Demo (if applicable):

Add side-by-side screenshots of the original and updated change.
Highlight any significant change(s).

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set?
What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR

Checklist

I haven't read the contributing guide
My code doesn't follow the style guidelines of this project
I haven't commented my code, particularly in hard-to-understand areas
I haven't checked if my changes generate no new warnings

Summary by mrge

Added an option to include no-show bookings in round robin (RR) calculations for event types.

New Features
- Added a toggle in the event type settings to include or exclude no-shows from RR host assignment.
- Updated backend logic and database schema to support this option.

…when getting bookings for RR

…bin`

vercel · 2025-05-01T18:09:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
cal	🛑 Canceled (Inspect)			May 2, 2025 3:14am

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
calcom-web-canary	⬜️ Ignored (Inspect)	Visit Preview		May 2, 2025 3:14am

joeauyeung · 2025-05-01T20:23:41Z

packages/features/eventtypes/components/tabs/assignment/EventTeamAssignmentTab.tsx

-                  </RadioArea.Group>
-                )}
-              />
+          {schedulingType === "ROUND_ROBIN" && (


Only show the RR distribution box for RR events

joeauyeung · 2025-05-01T20:25:41Z

packages/lib/server/repository/booking.ts

+      ...(!includeNoShowInRRCalculation
+        ? {
+            OR: [{ noShowHost: false }, { noShowHost: null }],
+          }
+        : {}),


Only if includeNoShow... is false then we add the noShowHost conditional

joeauyeung · 2025-05-01T20:25:50Z

packages/lib/server/repository/booking.ts

@@ -66,7 +65,7 @@ const buildWhereClauseForActiveBookings = ({
      },
    },
  ],
-  attendees: { some: { noShow: false } },
+  ...(!includeNoShowInRRCalculation ? { attendees: { some: { noShow: false } } } : {}),


Same here for the attendee no show prop

joeauyeung · 2025-05-01T20:26:19Z

packages/prisma/schema.prisma

@@ -164,6 +164,7 @@ model EventType {
  isRRWeightsEnabled                      Boolean                   @default(false)
  fieldTranslations                       EventTypeTranslation[]
  maxLeadThreshold                        Int?
+  includeNoShowInRRCalculation            Boolean                   @default(false)


This is the only change in the schema. Others are just auto formatting

joeauyeung · 2025-05-01T20:35:55Z

packages/lib/server/repository/eventType.ts

@@ -814,6 +815,7 @@ export class EventTypeRepository {
        rrSegmentQueryValue: true,
        isRRWeightsEnabled: true,
        maxLeadThreshold: true,
+        includeNoShowInRRCalculation: true,


Heads up @CarinaWolli the same logic that we use for determining the luckyUser is also used in getAvailableSlots. I added this as it was throwing a type error.

graphite-app · 2025-05-02T02:45:10Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (05/02/25)

1 reviewer was added to this PR based on Keith Williams's automation.

mrge-io

mrge found 6 issues across 16 files. View them in mrge.io

mrge-io · 2025-05-02T02:45:42Z

packages/lib/bookings/filterHostsByLeadThreshold.ts

@@ -98,6 +98,7 @@ export const filterHostsByLeadThreshold = async <T extends BaseHost<BaseUser>>({
      parentId?: number | null;
      rrResetInterval: RRResetInterval | null;
    } | null;
+    includeNoShowInRRCalculation: boolean;


Missing documentation for the new property that explains its purpose and impact on round robin calculations

mrge-io · 2025-05-02T02:45:42Z

packages/lib/server/getLuckyUser.ts

@@ -67,6 +67,7 @@ interface GetLuckyUserParams<T extends PartialUser> {
    id: number;
    isRRWeightsEnabled: boolean;
    team: { parentId?: number | null; rrResetInterval: RRResetInterval | null } | null;
+    includeNoShowInRRCalculation: boolean;


Missing default value for includeNoShowInRRCalculation parameter in getBookingsOfInterval function

mrge-io · 2025-05-02T02:45:42Z

packages/lib/server/repository/booking.ts

@@ -29,6 +29,7 @@ const buildWhereClauseForActiveBookings = ({
  endDate,
  users,
  virtualQueuesData,
+  includeNoShowInRRCalculation = false,


Default value in function parameter doesn't match type definition

mrge-io · 2025-05-02T02:45:42Z

packages/lib/server/repository/booking.ts

@@ -41,20 +42,18 @@
      selectedOptionIds: string | number | string[];
    };
  } | null;
+  includeNoShowInRRCalculation: boolean;


Required parameter follows optional parameters in function signature

mrge-io · 2025-05-02T02:45:42Z

packages/lib/server/repository/booking.ts

@@ -291,6 +267,7 @@
    startDate,
    endDate,
    virtualQueuesData,
+    includeNoShowInRRCalculation,


Missing documentation for new parameter in getAllBookingsForRoundRobin

mrge-io · 2025-05-02T02:45:42Z

packages/platform/atoms/event-types/hooks/useEventTypeForm.ts

@@ -127,6 +127,7 @@ export const useEventTypeForm = ({
      },
      isRRWeightsEnabled: eventType.isRRWeightsEnabled,
      maxLeadThreshold: eventType.maxLeadThreshold,
+      includeNoShowInRRCalculation: eventType.includeNoShowInRRCalculation,


Rule violated: Enforce Singular Naming for Single-Item Functions

Property name uses singular 'noShow' when referring to multiple no-show bookings

joeauyeung added 11 commits April 29, 2025 13:26

Show distribution option for RR scheduling type

aeadee6

Add includeNoShowInRRCalculation to event type schema

eab1548

Add includeNoShowInRRCalculation initial event type data

4ded5e2

Add FE option for includeNoShowInRRCalculation

b6855ff

Consider includeNoShowInRRCalculation when building where clause …

37f3a71

…when getting bookings for RR

Add includeNoShowInRRCalculation param to `getAllBookingsForRoundRo…

2adfeaf

…bin`

Add includeNoShow... param to GetLuckyUserParams

ff776b6

Pass includeNoShow... param to getBookingsOfInterval calls

fa0511a

Add FE option for includeNoShow... (actual commit)

018d0fa

Type fixes

151d632

Fix brackets

f970bba

github-actions bot added the ❗️ migrations contains migration files label May 1, 2025

keithwillcode added core area: core, team members only enterprise area: enterprise, audit log, organisation, SAML, SSO labels May 1, 2025

vercel bot had a problem deploying to Preview – api May 1, 2025 18:11 Failure

vercel bot had a problem deploying to Preview – dev May 1, 2025 18:14 Failure

Merge branch 'main' into do-not-count-noshows-in-rr

5470014

vercel bot had a problem deploying to Preview – api May 1, 2025 18:24 Failure

vercel bot deployed to Preview – dev May 1, 2025 18:38 View deployment

joeauyeung added 3 commits May 1, 2025 16:20

Add booking repository test

674656e

Remove unused method

7c743dc

Add translation

f34956e

joeauyeung commented May 1, 2025

View reviewed changes

Type fix

7ee80e9

joeauyeung commented May 1, 2025

View reviewed changes

Type fix

2a6c44f

vercel bot deployed to Preview – dev May 1, 2025 21:17 View deployment

vercel bot temporarily deployed to Preview – api May 1, 2025 21:28 Inactive

Test passing

aef93e1

joeauyeung and others added 2 commits May 1, 2025 17:53

Merge branch 'main' into do-not-count-noshows-in-rr

b7ef8b8

Fix tests

bf984fb

vercel bot deployed to Preview – api May 1, 2025 22:10 View deployment

vercel bot deployed to Preview – dev May 1, 2025 22:22 View deployment

Fix tests

9ce7153

vercel bot deployed to Preview – api May 2, 2025 01:09 View deployment

vercel bot deployed to Preview – dev May 2, 2025 01:16 View deployment

joeauyeung added 2 commits May 1, 2025 22:08

Fix test

3a28894

Type fixes

163ab7c

joeauyeung added the ready-for-e2e label May 2, 2025

joeauyeung marked this pull request as ready for review May 2, 2025 02:42

joeauyeung requested review from a team as code owners May 2, 2025 02:42

graphite-app bot requested a review from a team May 2, 2025 02:42

dosubot bot added event-types area: event types, event-types ✨ feature New feature or request labels May 2, 2025

mrge-io bot reviewed May 2, 2025

View reviewed changes

vercel bot temporarily deployed to Preview – api May 2, 2025 02:51 Inactive

vercel bot temporarily deployed to Preview – cal May 2, 2025 03:11 Inactive

vercel bot deployed to Preview – dev May 2, 2025 03:18 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add option to include no shows in RR calculations #21063

feat: Add option to include no shows in RR calculations #21063

joeauyeung commented May 1, 2025 •

edited by mrge-io bot

Loading

vercel bot commented May 1, 2025 •

edited

Loading

joeauyeung May 1, 2025

joeauyeung May 1, 2025

joeauyeung May 1, 2025

joeauyeung May 1, 2025

joeauyeung May 1, 2025

graphite-app bot commented May 2, 2025

mrge-io bot left a comment

mrge-io bot May 2, 2025

mrge-io bot May 2, 2025

mrge-io bot May 2, 2025

mrge-io bot May 2, 2025

mrge-io bot May 2, 2025

mrge-io bot May 2, 2025

feat: Add option to include no shows in RR calculations #21063

Are you sure you want to change the base?

feat: Add option to include no shows in RR calculations #21063

Conversation

joeauyeung commented May 1, 2025 • edited by mrge-io bot Loading

What does this PR do?

Visual Demo (For contributors especially)

Video Demo (if applicable):

Image Demo (if applicable):

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

Checklist

Summary by mrge

vercel bot commented May 1, 2025 • edited Loading

joeauyeung May 1, 2025

Choose a reason for hiding this comment

joeauyeung May 1, 2025

Choose a reason for hiding this comment

joeauyeung May 1, 2025

Choose a reason for hiding this comment

joeauyeung May 1, 2025

Choose a reason for hiding this comment

joeauyeung May 1, 2025

Choose a reason for hiding this comment

graphite-app bot commented May 2, 2025

Graphite Automations

mrge-io bot left a comment

Choose a reason for hiding this comment

mrge-io bot May 2, 2025

Choose a reason for hiding this comment

mrge-io bot May 2, 2025

Choose a reason for hiding this comment

mrge-io bot May 2, 2025

Choose a reason for hiding this comment

mrge-io bot May 2, 2025

Choose a reason for hiding this comment

mrge-io bot May 2, 2025

Choose a reason for hiding this comment

mrge-io bot May 2, 2025

Choose a reason for hiding this comment

joeauyeung commented May 1, 2025 •

edited by mrge-io bot

Loading

vercel bot commented May 1, 2025 •

edited

Loading