perf: replace OR conditions with UNION in bookings query #21067
+872
−248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
dosubot
bot
added
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/01/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (05/01/25)1 label was added to this PR based on Keith Williams's automation. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
Co-Authored-By: [email protected] <[email protected]>
…arameter mismatch Co-Authored-By: [email protected] <[email protected]>
…smatch Co-Authored-By: [email protected] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Performance Improvement for Booking Queries
This PR replaces the inefficient OR conditions in the booking queries with UNION queries, which are much more performant when querying large datasets. The optimized query is 212 times faster in production environments with millions of records.
Changes
Testing
Link to Devin run
https://app.devin.ai/sessions/b183a6281d8d4c04b94d015024c38139
Requested by: [email protected]
Summary by mrge
Replaced slow OR conditions in the bookings query with UNION-based raw SQL, making large booking queries over 200x faster.