fix: correct booker email input #21077
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
booking-page
sean-brydon
commented
May 2, 2025
| @@ -205,7 +205,16 @@ export const Components: Record<FieldType, Component> = { | |||
| if (!props) { | |||
| return <div />; | |||
| } | |||
| return <Widgets.TextWidget type="email" id={props.name} noLabel={true} {...props} />; | |||
There was a problem hiding this comment.
We use input field in the rest of this components file - not sure why we used widget here.
|
It affects both Routing Form field and Booker field right? |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/02/25)1 reviewer was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (05/02/25)1 label was added to this PR based on Keith Williams's automation. |
![mrge-io[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Yes but the one thats rendered in the form not the form builder that uses a different set of components cal.com/packages/app-store/routing-forms/components/react-awesome-query-builder/widgets.tsx The RAQB form builder uses these components where as the components rendered in booker/forms use the components in cal.com/packages/features/form-builder/Components.tsx |
emrysal
approved these changes
May 2, 2025
hariombalhara
approved these changes
May 2, 2025
E2E results are ready! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Uses the correct component in booker instead of the routing forms widgets
Summary by mrge
Fixed the booker email input to use the correct input component instead of the routing form widget. This ensures proper handling of email values in the form.