-
Notifications
You must be signed in to change notification settings - Fork 9.3k
refactor: v2 GET bookings default date range #21080
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
supalarry
wants to merge
14
commits into
main
Choose a base branch
from
lauris/cal-5690-refactor-v2-bookings-ensure-default-date-range
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: v2 GET bookings default date range #21080
supalarry
wants to merge
14
commits into
main
from
lauris/cal-5690-refactor-v2-bookings-ensure-default-date-range
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/02/25)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge found 9 issues across 11 files. View them in mrge.io
apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts
Outdated
Show resolved
Hide resolved
apps/api/v2/src/ee/bookings/2024-08-13/services/input.service.ts
Outdated
Show resolved
Hide resolved
apps/api/v2/src/modules/organizations/bookings/organizations-bookings.controller.e2e-spec.ts
Outdated
Show resolved
Hide resolved
apps/api/v2/src/modules/organizations/bookings/organizations-bookings.controller.e2e-spec.ts
Show resolved
Hide resolved
apps/api/v2/src/ee/bookings/2024-08-13/controllers/e2e/seated-bookings.e2e-spec.ts
Show resolved
Hide resolved
E2E results are ready! |
…default-date-range
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bookings
area: bookings, availability, timezones, double booking
core
area: core, team members only
platform
Anything related to our platform plan
ready-for-e2e
💻 refactor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linear CAL-5690
Summary by mrge
Refactored the v2 GET bookings endpoint to set a default date range of one month before to one month after today if no date filters are provided, and improved handling of "past" and "upcoming" status filters.