-
Notifications
You must be signed in to change notification settings - Fork 9.3k
perf: remove unnecessary routes from middleware #21089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
// Routes allowed for POST method (matching `POST_METHODS_ALLOWED_APP_ROUTES` array) | ||
"/settings/my-account/general", | ||
"/settings/developer/webhooks", | ||
"/settings/developer/api-keys", | ||
"/teams", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can simply remove these routes from config.matcher
and not need to maintain POST_METHODS_ALLOWED_APP_ROUTES
array
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (05/02/25)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mrge reviewed 1 file and found no issues. Review this PR in mrge.io.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
E2E results are ready! |
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
e.g., visit http://localhost:3000/settings/my-account/general and see if changing language makes a POST request to the page.