Skip to content

Conversation

dhairyashiil
Copy link
Member

@dhairyashiil dhairyashiil commented Oct 8, 2025

What does this PR do?

Visual Demo (For contributors especially)

Screen.Recording.2025-10-09.at.12.24.03.AM.mov

Copy link

vercel bot commented Oct 8, 2025

@dhairyashiil is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Oct 8, 2025
@graphite-app graphite-app bot requested a review from a team October 8, 2025 18:53
@github-actions github-actions bot added event-types area: event types, event-types 🐛 bug Something isn't working labels Oct 8, 2025
@keithwillcode keithwillcode added the community-interns The team responsible for reviewing, testing and shipping low/medium community PRs label Oct 8, 2025
Copy link
Contributor

coderabbitai bot commented Oct 8, 2025

Walkthrough

Updated EventAdvancedTab.tsx to change initialization of the interfaceLanguageVisible state. It now checks whether formMethods.getValues("interfaceLanguage") !== null instead of coercing the value to boolean. This treats an empty string as a visible state, affecting the initial visibility of the interface language UI. The behavior on toggle remains: unchecking sets the value to null; checking sets it to an empty string. No exported or public declarations were altered.

Pre-merge checks and finishing touches

✅ Passed checks (5 passed)
Check name Status Explanation
Title Check ✅ Passed The title clearly identifies the specific UI component being fixed, namely the interface language toggle, and concisely reflects the main purpose of the changeset.
Linked Issues Check ✅ Passed The change modifies the initialization logic of the interface language toggle so it correctly reflects saved values and persists its state after saving, thereby directly addressing the issue of the toggle not applying or displaying the saved interface language setting (#24367 and CAL-6551).
Out of Scope Changes Check ✅ Passed The only modification is within the interface language toggle component to adjust its visibility logic, and there are no unrelated or extraneous changes outside the scope of fixing the toggle behavior.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description clearly references the two issues being addressed and includes a visual demo link that directly relates to the interface language toggle bug, indicating that the description is on-topic and relevant to the changeset. It specifies what the PR does in terms of issue fixes, aligning with the objective of fixing the interface language toggle behavior. Although it does not detail the code changes, it still provides sufficient context for reviewers to understand the purpose of the PR.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@dosubot dosubot bot added the ui area: UI, frontend, button, form, input label Oct 8, 2025
@anikdhabal anikdhabal enabled auto-merge (squash) October 8, 2025 22:50
Copy link
Contributor

github-actions bot commented Oct 8, 2025

E2E results are ready!

@github-actions github-actions bot added the Medium priority Created by Linear-GitHub Sync label Oct 10, 2025
@IbrahimLoveForJS
Copy link

is it still available?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working community Created by Linear-GitHub Sync community-interns The team responsible for reviewing, testing and shipping low/medium community PRs event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync ready-for-e2e size/XS ui area: UI, frontend, button, form, input

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The interface language in event type settings does not work; after saving.

4 participants