-
Notifications
You must be signed in to change notification settings - Fork 10.8k
fix: improve empty state when no event types are configured #24398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@Vibgitcode27 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughReplaced the skeleton placeholder UI in packages/features/eventtypes/components/EmptyPage.tsx with a concrete empty-state component. Removed SkeletonEventType and its stacked layout. Added a bordered, centered container rendering an Icon (calendar), a localized header, and a descriptive paragraph. Introduced import of Icon from @calcom/ui/components/icon and useLocale for translations. Changed the component to a default export function: EmptyPage({ name }: { name: string }). Updated rendering to a single self-contained UI block instead of multiple skeleton elements. Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (1)
🧰 Additional context used📓 Path-based instructions (3)**/*.tsx📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Files:
**/*.{ts,tsx}📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Files:
**/*.{ts,tsx,js,jsx}⚙️ CodeRabbit configuration file
Files:
🧠 Learnings (1)📓 Common learnings
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
E2E results are ready! |
What does this PR do?
This PR makes a small UI improvement to the empty state so it looks cleaner.
It’s not a major issue, but I thought it might be worth improving.
If you feel this change isn’t necessary, please feel free to close this PR.
Image Demo (if applicable):
Before fix:

After fix:

Mandatory Tasks (DO NOT REMOVE)
Checklist