feat: Add subscription start, trial end, and dates to billing tables #24408
Conversation
keithwillcode
added
core
WalkthroughAdds subscription date fields across billing: Prisma schema and a migration add subscriptionStart, subscriptionTrialEnd, and subscriptionEnd to TeamBilling and OrganizationBilling. IBillingRepositoryCreateArgs gains optional Date fields for subscriptionStart, subscriptionTrialEnd, and subscriptionEnd and SubscriptionStatus gains new members (INCOMPLETE, INCOMPLETE_EXPIRED, UNPAID, PAUSED). StripeBillingService adds static extractSubscriptionDates (converts Stripe epoch-second fields to JS Dates) and a Stripe->internal status mapper. Routes and webhook handlers call extractSubscriptionDates and pass subscriptionStart into InternalTeamBilling.saveTeamBilling. Multiple import-path typos for StripeBillingService were corrected. EventType public unique constraints removed. Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| }); | ||
|
|
||
| // Get the Stripe subscription object | ||
| const stripeSubscription = await stripe.subscriptions.retrieve(paymentSubscriptionId); |
There was a problem hiding this comment.
The data returned from the invoice_paid event doesn't contain the subscription info so we need to fetch that from Stripe.
Since this is happening in the background, the extra Stripe call won't affect UX.
E2E results are ready! |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/prisma/schema.prisma (1)
250-252: Remove unrelated changes to EventType unique constraints.The removal of these three unique constraints on EventType is not mentioned in the PR objectives and appears unrelated to adding billing date fields. This change could have significant implications:
- Allows duplicate slugs per user/team, which could break routing or cause conflicts
- Allows duplicate parentId entries, which could create data integrity issues
If these constraint removals are intentional, they should be in a separate PR with proper justification and testing.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (6)
apps/web/app/api/teams/api/create/route.ts(1 hunks)apps/web/app/api/teams/create/route.ts(1 hunks)packages/features/ee/billing/api/webhook/_invoice.paid.org.ts(3 hunks)packages/features/ee/billing/repository/IBillingRepository.ts(1 hunks)packages/prisma/migrations/20251010135752_billing_tables_add_dates/migration.sql(1 hunks)packages/prisma/schema.prisma(4 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
**/*.ts: For Prisma queries, only select data you need; never useinclude, always useselect
Ensure thecredential.keyfield is never returned from tRPC endpoints or APIs
Files:
apps/web/app/api/teams/api/create/route.tspackages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/ee/billing/repository/IBillingRepository.tsapps/web/app/api/teams/create/route.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()in hot paths like loops
Files:
apps/web/app/api/teams/api/create/route.tspackages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/ee/billing/repository/IBillingRepository.tsapps/web/app/api/teams/create/route.ts
**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.
Files:
apps/web/app/api/teams/api/create/route.tspackages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/ee/billing/repository/IBillingRepository.tsapps/web/app/api/teams/create/route.ts
**/*Repository.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Repository files must include
Repositorysuffix, prefix with technology if applicable (e.g.,PrismaAppRepository.ts), and use PascalCase matching the exported class
Files:
packages/features/ee/billing/repository/IBillingRepository.ts
🧬 Code graph analysis (1)
packages/features/ee/billing/api/webhook/_invoice.paid.org.ts (1)
packages/app-store/_utils/stripe.ts (1)
stripe(70-72)
🔇 Additional comments (8)
apps/web/app/api/teams/api/create/route.ts (1)
69-70: LGTM!The subscriptionStart calculation correctly converts Unix seconds to milliseconds, and the comment clearly explains the conversion.
packages/prisma/migrations/20251010135752_billing_tables_add_dates/migration.sql (1)
1-9: LGTM!The migration correctly adds the three new date columns to both billing tables as nullable fields, which is appropriate for existing records.
packages/prisma/schema.prisma (2)
2619-2621: LGTM!The addition of
subscriptionStart,subscriptionTrialEnd, andsubscriptionEndfields to TeamBilling correctly implements the schema changes for the new billing date tracking feature.
2637-2639: LGTM!The addition of
subscriptionStart,subscriptionTrialEnd, andsubscriptionEndfields to OrganizationBilling correctly implements the schema changes for the new billing date tracking feature.apps/web/app/api/teams/create/route.ts (1)
99-100: LGTM!The subscriptionStart calculation is correct and consistent with the implementation in the other team creation route. The conversion from Unix seconds to milliseconds is properly explained.
packages/features/ee/billing/api/webhook/_invoice.paid.org.ts (2)
6-6: Consider upgrading the Stripe SDK version.Based on learnings, the current Stripe SDK version (using API version 2020-08-27 as shown in packages/app-store/_utils/stripe.ts) is significantly outdated. The Stripe Node SDK has progressed through many major versions since 3.x, with improvements including:
- Modern TypeScript support and generated types
- Better retry/backoff behavior
- Support for newer Stripe API features
- Security fixes
While not blocking for this PR, consider planning an upgrade to benefit from these improvements.
Based on learnings
100-113: LGTM!The implementation correctly:
- Fetches the Stripe subscription to access the
createdtimestamp (as explained in the past review comment)- Converts Unix seconds to milliseconds for the Date constructor
- Populates subscriptionStart in the billing record
The extra Stripe API call in the background webhook handler is justified and won't impact user experience.
packages/features/ee/billing/repository/IBillingRepository.ts (1)
40-42: Verify population of subscriptionTrialEnd and subscriptionEnd fields.The interface correctly adds all three date fields, but only
subscriptionStartis currently populated in the codebase. Consider whethersubscriptionTrialEndandsubscriptionEndshould also be populated from Stripe data:
subscriptionTrialEnd: Available assubscription.trial_endin StripesubscriptionEnd: Available assubscription.ended_atorsubscription.cancel_atin StripeIf these fields are intended for future use, this is fine as they're optional. However, if they should be populated now, the webhook and route handlers should be updated accordingly.
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
| const { subscriptionStart } = | ||
| StripeBillingService.extractSubscriptionDates(checkoutSessionSubscription); | ||
|
|
There was a problem hiding this comment.
Since we always have to convert Stripe's time from unix seconds to milliseconds when passing to Date(), I decided to create a static method on the StripeBillingService
| }); | ||
|
|
||
| vi.mock("@calcom/features/ee/billing/stripe-billling-service", () => { | ||
| vi.mock("@calcom/features/ee/billing/stripe-billing-service", () => { |
There was a problem hiding this comment.
I noticed that the file name for the StripeBillingService had a typo so I'm fixing that in this PR.
| invoice_creation: { | ||
| enabled: true, | ||
| }, | ||
| // eslint-disable-next-line |
There was a problem hiding this comment.
Lint fix. Since the checkout session mode is "payment" the invoice_creation is a valid argument but this throws a type error.
|
|
||
| async handleSubscriptionCreation(subscriptionId: string) { | ||
| throw new Error("Method not implemented."); | ||
| throw new Error(`Method not implemented for subscription id ${subscriptionId}`); |
| return price; | ||
| } | ||
|
|
||
| static extractSubscriptionDates(subscription: { |
There was a problem hiding this comment.
Single method to convert Stripe's dates to Date object
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
packages/features/ee/billing/stripe-billing-service.ts (1)
61-61: Clarify the purpose of the eslint-disable comment.The
eslint-disable-next-linecomment lacks context about which rule is being disabled and why. Consider adding a brief explanation or the specific rule name.Example:
- // eslint-disable-next-line + // eslint-disable-next-line @typescript-eslint/no-explicit-any -- Stripe session type doesn't match exactlyapps/web/app/api/teams/create/route.ts (2)
91-91: Consider extracting and storing all subscription date fields.The
extractSubscriptionDatesmethod returns three fields (subscriptionStart,subscriptionTrialEnd,subscriptionEndDate), but onlysubscriptionStartis currently extracted and stored. Since the PR adds all three fields to the billing schema and the data is already being computed, consider destructuring and passing all three tosaveTeamBillingfor completeness.Apply this diff to extract all date fields:
- const { subscriptionStart } = StripeBillingService.extractSubscriptionDates(subscription); + const { subscriptionStart, subscriptionTrialEnd, subscriptionEndDate } = StripeBillingService.extractSubscriptionDates(subscription);Then pass all three fields to
saveTeamBilling:await internalBillingService.saveTeamBilling({ teamId: team.id, subscriptionId: subscription.id, subscriptionItemId: subscription.items.data[0].id, customerId: subscription.customer as string, // TODO: Implement true subscription status when webhook events are implemented status: SubscriptionStatus.ACTIVE, planName: Plan.TEAM, // Stripe returns time in unix seconds but new Date() expects milliseconds subscriptionStart, + subscriptionTrialEnd, + subscriptionEnd: subscriptionEndDate, });
101-102: Consider updating the comment for clarity.The comment about unix seconds and milliseconds conversion is placed here, but the actual conversion happens inside
StripeBillingService.extractSubscriptionDates()at line 91. By the timesubscriptionStartreaches this point, it's already aDateobject. Consider updating the comment to clarify this, or remove it since the conversion is documented in theextractSubscriptionDatesmethod.Example clarification:
- // Stripe returns time in unix seconds but new Date() expects milliseconds - subscriptionStart, + subscriptionStart, // Already converted from Stripe's unix seconds to Date
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (16)
apps/web/app/api/teams/api/create/route.ts(3 hunks)apps/web/app/api/teams/create/route.ts(3 hunks)apps/web/lib/pages/auth/verify-email.test.ts(1 hunks)apps/web/lib/pages/auth/verify-email.ts(1 hunks)packages/app-store/stripepayment/lib/getCustomerAndCheckoutSession.ts(1 hunks)packages/features/auth/signup/handlers/calcomHandler.ts(1 hunks)packages/features/ee/billing/api/webhook/_invoice.paid.org.ts(3 hunks)packages/features/ee/billing/credit-service.test.ts(1 hunks)packages/features/ee/billing/credit-service.ts(1 hunks)packages/features/ee/billing/stripe-billing-service.test.ts(1 hunks)packages/features/ee/billing/stripe-billing-service.ts(3 hunks)packages/features/ee/organizations/lib/OrganizationPaymentService.test.ts(1 hunks)packages/features/ee/organizations/lib/OrganizationPaymentService.ts(1 hunks)packages/trpc/server/routers/loggedInViewer/stripeCustomer.handler.ts(1 hunks)packages/trpc/server/routers/viewer/credits/buyCredits.handler.ts(1 hunks)packages/trpc/server/routers/viewer/me/updateProfile.handler.ts(1 hunks)
✅ Files skipped from review due to trivial changes (7)
- apps/web/lib/pages/auth/verify-email.test.ts
- packages/trpc/server/routers/loggedInViewer/stripeCustomer.handler.ts
- packages/features/ee/billing/credit-service.ts
- packages/features/ee/billing/credit-service.test.ts
- packages/features/ee/organizations/lib/OrganizationPaymentService.test.ts
- apps/web/lib/pages/auth/verify-email.ts
- packages/trpc/server/routers/viewer/credits/buyCredits.handler.ts
🧰 Additional context used
📓 Path-based instructions (4)
**/*Service.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Service files must include
Servicesuffix, use PascalCase matching exported class, and avoid generic names (e.g.,MembershipService.ts)
Files:
packages/features/ee/organizations/lib/OrganizationPaymentService.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
**/*.ts: For Prisma queries, only select data you need; never useinclude, always useselect
Ensure thecredential.keyfield is never returned from tRPC endpoints or APIs
Files:
packages/features/ee/organizations/lib/OrganizationPaymentService.tsapps/web/app/api/teams/api/create/route.tspackages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/auth/signup/handlers/calcomHandler.tspackages/features/ee/billing/stripe-billing-service.tsapps/web/app/api/teams/create/route.tspackages/features/ee/billing/stripe-billing-service.test.tspackages/trpc/server/routers/viewer/me/updateProfile.handler.tspackages/app-store/stripepayment/lib/getCustomerAndCheckoutSession.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()in hot paths like loops
Files:
packages/features/ee/organizations/lib/OrganizationPaymentService.tsapps/web/app/api/teams/api/create/route.tspackages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/auth/signup/handlers/calcomHandler.tspackages/features/ee/billing/stripe-billing-service.tsapps/web/app/api/teams/create/route.tspackages/features/ee/billing/stripe-billing-service.test.tspackages/trpc/server/routers/viewer/me/updateProfile.handler.tspackages/app-store/stripepayment/lib/getCustomerAndCheckoutSession.ts
**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.
Files:
packages/features/ee/organizations/lib/OrganizationPaymentService.tsapps/web/app/api/teams/api/create/route.tspackages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/auth/signup/handlers/calcomHandler.tspackages/features/ee/billing/stripe-billing-service.tsapps/web/app/api/teams/create/route.tspackages/features/ee/billing/stripe-billing-service.test.tspackages/trpc/server/routers/viewer/me/updateProfile.handler.tspackages/app-store/stripepayment/lib/getCustomerAndCheckoutSession.ts
🧬 Code graph analysis (3)
apps/web/app/api/teams/api/create/route.ts (1)
packages/features/ee/billing/stripe-billing-service.ts (1)
StripeBillingService(5-213)
packages/features/ee/billing/api/webhook/_invoice.paid.org.ts (2)
packages/app-store/_utils/stripe.ts (1)
stripe(70-72)packages/features/ee/billing/stripe-billing-service.ts (1)
StripeBillingService(5-213)
apps/web/app/api/teams/create/route.ts (1)
packages/features/ee/billing/stripe-billing-service.ts (1)
StripeBillingService(5-213)
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Install dependencies / Yarn install & cache
🔇 Additional comments (11)
packages/trpc/server/routers/viewer/me/updateProfile.handler.ts (1)
7-7: LGTM!Import path typo corrected from "stripe-billling-service" to "stripe-billing-service".
packages/features/ee/billing/stripe-billing-service.test.ts (1)
4-4: LGTM!Import path typo corrected.
packages/app-store/stripepayment/lib/getCustomerAndCheckoutSession.ts (1)
1-1: LGTM!Import path typo corrected.
packages/features/ee/organizations/lib/OrganizationPaymentService.ts (1)
1-1: LGTM!Import path typo corrected.
packages/features/auth/signup/handlers/calcomHandler.ts (1)
8-8: LGTM!Import path typo corrected.
packages/features/ee/billing/api/webhook/_invoice.paid.org.ts (2)
4-7: LGTM!Import path corrected and necessary Stripe client imported for subscription retrieval.
101-116: LGTM!Correctly retrieves the Stripe subscription and extracts
subscriptionStartfor billing records. The additional Stripe API call is acceptable in this background webhook context.The comment on line 114 about UNIX seconds to milliseconds conversion is slightly redundant since the conversion is already handled by
extractSubscriptionDates, but it serves as helpful documentation.apps/web/app/api/teams/api/create/route.ts (2)
8-8: LGTM!Import added for subscription date extraction.
60-76: LGTM!Correctly extracts
subscriptionStartfrom the expanded Stripe subscription and passes it to the billing service. The checkout session retrieval at line 100-102 properly expands the subscription to ensure all date fields are available.The comment on line 73 about UNIX seconds to milliseconds conversion is slightly redundant since
extractSubscriptionDateshandles this, but it provides helpful context.packages/features/ee/billing/stripe-billing-service.ts (1)
131-131: LGTM!Error message improvement provides better context by including the subscription ID.
apps/web/app/api/teams/create/route.ts (1)
8-8: LGTM!The import is correctly added and used in the file to extract subscription dates.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/app/api/teams/api/create/route.ts (1)
40-58: Prefer Prismaselectoverinclude.The Prisma query uses
include: { members: true }which fetches all member fields. Per coding guidelines, you should useselectto explicitly specify only the fields you need.As per coding guidelines.
Apply this diff to use
selectinstead ofinclude:const finalizedTeam = await prisma.team.update({ where: { id: checkoutSessionMetadata.pendingPaymentTeamId }, data: { pendingPayment: false, members: { create: { userId: checkoutSessionMetadata.ownerId as number, role: MembershipRole.OWNER, accepted: true, }, }, metadata: { paymentId: checkoutSession.id, subscriptionId: checkoutSessionSubscription.id || null, subscriptionItemId: checkoutSessionSubscription.items.data[0].id || null, }, }, - include: { members: true }, + select: { + id: true, + name: true, + slug: true, + members: { + select: { + id: true, + userId: true, + teamId: true, + role: true, + accepted: true, + disableImpersonation: true, + }, + }, + }, });
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
apps/web/app/api/teams/api/create/route.ts(3 hunks)apps/web/app/api/teams/create/route.ts(3 hunks)packages/features/ee/billing/api/webhook/_invoice.paid.org.ts(3 hunks)packages/features/ee/billing/stripe-billing-service.ts(3 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- apps/web/app/api/teams/create/route.ts
🧰 Additional context used
📓 Path-based instructions (3)
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
**/*.ts: For Prisma queries, only select data you need; never useinclude, always useselect
Ensure thecredential.keyfield is never returned from tRPC endpoints or APIs
Files:
packages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/ee/billing/stripe-billing-service.tsapps/web/app/api/teams/api/create/route.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()in hot paths like loops
Files:
packages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/ee/billing/stripe-billing-service.tsapps/web/app/api/teams/api/create/route.ts
**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.
Files:
packages/features/ee/billing/api/webhook/_invoice.paid.org.tspackages/features/ee/billing/stripe-billing-service.tsapps/web/app/api/teams/api/create/route.ts
🧬 Code graph analysis (2)
packages/features/ee/billing/api/webhook/_invoice.paid.org.ts (2)
packages/app-store/_utils/stripe.ts (1)
stripe(70-72)packages/features/ee/billing/stripe-billing-service.ts (1)
StripeBillingService(5-213)
apps/web/app/api/teams/api/create/route.ts (1)
packages/features/ee/billing/stripe-billing-service.ts (1)
StripeBillingService(5-213)
🔇 Additional comments (4)
packages/features/ee/billing/stripe-billing-service.ts (2)
131-131: LGTM: Improved error message.The error message now includes the subscription ID, providing better context for debugging.
201-212: LGTM: Subscription date conversion is correct.The static helper correctly converts Stripe's Unix timestamps (seconds) to JavaScript Date objects (milliseconds) and properly handles optional/nullable fields.
packages/features/ee/billing/api/webhook/_invoice.paid.org.ts (1)
101-114: LGTM: Subscription start date extraction is correct.The code properly retrieves the Stripe subscription object and extracts
subscriptionStartfor persistence. The extra API call is acceptable in this webhook handler context since it runs in the background. The outer try-catch block (line 75) will handle any errors from the subscription retrieval.Note: Only
subscriptionStartis currently populated, which aligns with the PR scope. The schema supportssubscriptionTrialEndandsubscriptionEndas well, which could be populated in future iterations.apps/web/app/api/teams/api/create/route.ts (1)
61-73: LGTM: Subscription start date extraction is correct.The code properly extracts
subscriptionStartfrom the checkout session subscription and passes it to the billing service. The formatting and logic are sound.Note: Only
subscriptionStartis currently populated, which aligns with the PR scope. The schema supportssubscriptionTrialEndandsubscriptionEndas well, which could be populated in future iterations.
joeauyeung
force-pushed
the
billing-table-add-dates
branch
from
bee4edf to
82a2e91
Compare
| return { subscriptionStart, subscriptionTrialEnd, subscriptionEnd }; | ||
| } | ||
|
|
||
| static mapStripeStatusToCalStatus = ({ |
There was a problem hiding this comment.
Commit meant for #24390 but keeping it in here because it's stacked on top.
- Add INCOMPLETE, INCOMPLETE_EXPIRED, UNPAID, PAUSED enum values - These values are referenced in stripe-billing-service.ts status mapping - Fixes type errors in billing-related code Co-Authored-By: [email protected] <[email protected]>
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/features/ee/billing/repository/IBillingRepository.ts (1)
44-46: KeepBillingRecordin sync with the new subscription fields.We accept these timestamps in
create, butBillingRecordstill omits them, so repository implementations can’t surface the stored values without casts/any. Please extendBillingRecord(and any DTOs mirroring it) to include the optional date columns so the types stay coherent.export interface BillingRecord { id: string; teamId: number; subscriptionId: string; subscriptionItemId: string; customerId: string; planName: Plan; status: SubscriptionStatus; + subscriptionStart?: Date | null; + subscriptionTrialEnd?: Date | null; + subscriptionEnd?: Date | null; }
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
packages/features/ee/billing/repository/IBillingRepository.ts(2 hunks)
🧰 Additional context used
📓 Path-based instructions (4)
**/*Repository.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Repository files must include
Repositorysuffix, prefix with technology if applicable (e.g.,PrismaAppRepository.ts), and use PascalCase matching the exported class
Files:
packages/features/ee/billing/repository/IBillingRepository.ts
**/*.ts
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
**/*.ts: For Prisma queries, only select data you need; never useinclude, always useselect
Ensure thecredential.keyfield is never returned from tRPC endpoints or APIs
Files:
packages/features/ee/billing/repository/IBillingRepository.ts
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()in hot paths like loops
Files:
packages/features/ee/billing/repository/IBillingRepository.ts
**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.
Files:
packages/features/ee/billing/repository/IBillingRepository.ts
2 participants
What does this PR do?
subscriptionStart,subscriptionTrialEndandsubscriptionEndfields to theTeamBillingandOrganizationBillingtables.subscriptionStartdates when new organizations and teams are createdstripe-billing-servicefile (billling -> billing)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?