-
Notifications
You must be signed in to change notification settings - Fork 11.6k
feat: enable onboarding-v3 feature flag #26865
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
E2E results are ready! |
keithwillcode
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests are consistently failing @sean-brydon
Pull request was converted to draft
…-onboarding-v3-1768472009
What does this PR do?
Adds a database migration to enable the
onboarding-v3feature flag globally. The feature flag was previously added in migration20251005102651_add_onboarding_v3_feature_flagwithenabled=false. This migration updates it toenabled=true.Also updates the onboarding E2E tests to conditionally run either the V1 or V3 flow based on the feature flag status.
Summary of Changes
Database Migration:
onboarding-v3feature flag globallyE2E Test Updates:
testOnboardingtotestOnboardingV1with feature flag check to skip when V3 is enabledtestOnboardingV3function that tests the new onboarding flow (plan selection → personal settings → calendar)Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Database Migration:
yarn workspace @calcom/prisma db-migrate), check the Feature table to confirmonboarding-v3hasenabled=trueE2E Tests:
onboarding-v3feature flag enabled - V3 tests should run, V1 tests should skipHuman Review Checklist
onboarding-v3globally is the intended behaviorpage.getByText("Personal"),page.getByLabel("Your name"),page.getByRole("button", { name: "Skip for now" })) match the actual UI elements - these were inferred from source code reviewdata-testidattributes, so tests rely on text content/ARIA labels which may be more fragileLink to Devin run: https://app.devin.ai/sessions/0bea3e60c75c498a8708733551122a52
Requested by: @sean-brydon