Skip to content

Conversation

@sean-brydon
Copy link
Member

@sean-brydon sean-brydon commented Jan 15, 2026

What does this PR do?

Adds a database migration to enable the onboarding-v3 feature flag globally. The feature flag was previously added in migration 20251005102651_add_onboarding_v3_feature_flag with enabled=false. This migration updates it to enabled=true.

Also updates the onboarding E2E tests to conditionally run either the V1 or V3 flow based on the feature flag status.

Summary of Changes

Database Migration:

  • Enables onboarding-v3 feature flag globally

E2E Test Updates:

  • Renamed testOnboarding to testOnboardingV1 with feature flag check to skip when V3 is enabled
  • Added new testOnboardingV3 function that tests the new onboarding flow (plan selection → personal settings → calendar)
  • V3 tests skip when the feature flag is disabled, V1 tests skip when enabled
  • Both test suites run for GOOGLE, CAL, and SAML identity providers

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - no documentation changes needed.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Database Migration:

  1. After running migrations (yarn workspace @calcom/prisma db-migrate), check the Feature table to confirm onboarding-v3 has enabled=true
  2. Verify the onboarding v3 flow is active for users

E2E Tests:

  1. With onboarding-v3 feature flag enabled - V3 tests should run, V1 tests should skip
  2. Verify the V3 flow tests correctly navigate through: plan selection → personal settings → calendar → event-types

Human Review Checklist

  • Confirm enabling onboarding-v3 globally is the intended behavior
  • Verify there are no downstream effects that need to be considered before enabling this feature
  • Verify the V3 test selectors (page.getByText("Personal"), page.getByLabel("Your name"), page.getByRole("button", { name: "Skip for now" })) match the actual UI elements - these were inferred from source code review
  • Note: V3 onboarding components don't have data-testid attributes, so tests rely on text content/ARIA labels which may be more fragile

Link to Devin run: https://app.devin.ai/sessions/0bea3e60c75c498a8708733551122a52
Requested by: @sean-brydon

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@github-actions github-actions bot added the ❗️ migrations contains migration files label Jan 15, 2026
@sean-brydon sean-brydon marked this pull request as ready for review January 15, 2026 10:16
@sean-brydon sean-brydon requested a review from a team as a code owner January 15, 2026 10:16
@graphite-app graphite-app bot requested a review from a team January 15, 2026 10:17
@graphite-app graphite-app bot added consumer core area: core, team members only labels Jan 15, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

volnei
volnei previously approved these changes Jan 15, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 15, 2026

E2E results are ready!

@keithwillcode keithwillcode enabled auto-merge (squash) January 16, 2026 07:48
@keithwillcode keithwillcode added this to the v6.2 milestone Jan 16, 2026
Copy link
Contributor

@keithwillcode keithwillcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are consistently failing @sean-brydon

@github-actions github-actions bot marked this pull request as draft January 16, 2026 07:53
auto-merge was automatically disabled January 16, 2026 07:53

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

consumer core area: core, team members only ❗️ migrations contains migration files ready-for-e2e size/M

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants