-
Notifications
You must be signed in to change notification settings - Fork 11.6k
feat: rename font-cal to font-heading and centralize font loading #26937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ans UI (#26064)" (#26759) This reverts commit a4d4626, bringing back the original PR #26064 changes. Co-Authored-By: [email protected] <[email protected]>
- Change fontSans from Cal Sans UI to Inter (Google Fonts) - Keep fontHeading as Cal Sans SemiBold (same as original calFont) - Remove unused CalSansUI font file - Update README to reflect the correct font setup This keeps Inter as the body font while using Cal Sans SemiBold for headings, matching the original font behavior on main. Co-Authored-By: [email protected] <[email protected]>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 73 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/onboarding/components/OnboardingCard.tsx">
<violation number="1" location="apps/web/modules/onboarding/components/OnboardingCard.tsx:68">
P2: Replacing `[container-type:size]` with `@container-[size]` removes the `container-type` property, so this card is no longer a queryable container and any child container queries will no longer fire.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
Reverts incorrect @container-[size] back to [container-type:size]. The original change removed the container-type property, which broke container queries for child elements. Addresses Cubic AI review feedback (confidence 9/10). Co-Authored-By: unknown <>
What does this PR do?
This is a partial reapplication of #26064, bringing back the class/variable renaming while keeping Inter for body text (instead of switching body text to Cal Sans UI which caused the original PR to be reverted in #26759).
Changes:
--font-calCSS variable to--font-headingfont-calTailwind class tofont-heading@coss/ui/fontspackage withfontSans(Inter) andfontHeading(Cal Sans SemiBold)CalSans-SemiBold.woff2fromapps/web/fonts/topackages/coss-ui/src/fonts/font-semibold,font-medium,font-extrabold) from elements usingfont-headingsince Cal Sans SemiBold is inherently semibold<style>tags for CSS variables in favor of using font.variableproperties on body classThis fixes the DialogTitle font weight issue where titles appeared thin/normal after the original PR was reverted.
Link to Devin run: https://app.devin.ai/sessions/ccf24fb0875d405db9f35802a2afb12f
Requested by: @eunjae-lee
Mandatory Tasks (DO NOT REMOVE)
packages/coss-ui/src/fonts/.How should this be tested?
app/layout.tsx) and Pages Router (pages/_document.tsx)Human Review Checklist
font-calor--font-calreferences were missed in the renameapps/web/fonts/topackages/coss-ui/src/fonts/works correctly