Skip to content

Conversation

@anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Jan 16, 2026

What does this PR do?


Summary by cubic

Skips scheduling "before event" reminders when the computed date is already in the past, preventing outdated notifications. Addresses CAL-7061.

  • Bug Fixes
    • Reminders: Added past-date check and early return across email, SMS, WhatsApp, and lazy email workflows; logs a debug message when skipped.

Written for commit f6dd425. Summary will update on new commits.

@linear
Copy link

linear bot commented Jan 16, 2026

@github-actions github-actions bot added the 🐛 bug Something isn't working label Jan 16, 2026
@graphite-app graphite-app bot added the core area: core, team members only label Jan 16, 2026
@anikdhabal anikdhabal enabled auto-merge (squash) January 16, 2026 15:29
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 6 files

Prompt for AI agents (all issues)

Check if these issues are valid — if so, understand the root cause of each and fix them.


<file name="apps/web/playwright/filter-segment.e2e.ts">

<violation number="1" location="apps/web/playwright/filter-segment.e2e.ts:121">
P2: This test no longer reloads the page, so it doesn’t actually verify that filter segments persist across reloads. Reintroduce the reload to keep the coverage aligned with the test’s intent.</violation>
</file>

Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.

@github-actions
Copy link
Contributor

Devin AI is addressing Cubic AI's review feedback

A Devin session has been created to address the issues identified by Cubic AI.

View Devin Session

@devin-ai-integration
Copy link
Contributor

I reviewed the Cubic AI feedback on this PR. The only issue identified (regarding the removed page.reload() in the filter-segment test) has a confidence score of 8/10, which is below the 9/10 threshold required for automated fixes.

Since the confidence score doesn't meet the threshold, no changes were made. If you believe this issue should still be addressed, please let me know and I can implement the fix manually.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 16, 2026
@anikdhabal anikdhabal added this to the v6.2 milestone Jan 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working core area: core, team members only size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

All reminders (2, 3, 4 days out) sent out even booking hours in advance.

2 participants