-
Notifications
You must be signed in to change notification settings - Fork 11.6k
fix: skip reminders when scheduled date is in the past #26942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/playwright/filter-segment.e2e.ts">
<violation number="1" location="apps/web/playwright/filter-segment.e2e.ts:121">
P2: This test no longer reloads the page, so it doesn’t actually verify that filter segments persist across reloads. Reintroduce the reload to keep the coverage aligned with the test’s intent.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
|
I reviewed the Cubic AI feedback on this PR. The only issue identified (regarding the removed Since the confidence score doesn't meet the threshold, no changes were made. If you believe this issue should still be addressed, please let me know and I can implement the fix manually. |
What does this PR do?
Summary by cubic
Skips scheduling "before event" reminders when the computed date is already in the past, preventing outdated notifications. Addresses CAL-7061.
Written for commit f6dd425. Summary will update on new commits.