Skip to content

Conversation

@Ryukemeister
Copy link
Contributor

What does this PR do?

Fixes the "Check API v2 breaking changes" CI workflow which was failing with TypeScript errors like Cannot find module '@calcom/platform-libraries/pbac'.

The workflow was missing a build step for platform packages before running yarn generate-swagger. The swagger generation needs to compile TypeScript, but the platform packages' dist/ folders didn't exist yet, causing module resolution failures.

This adds the same build step used in e2e-api-v2.yml and api-v2-unit-tests.yml workflows.

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. N/A - CI workflow change only.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works. N/A - this fixes the CI workflow itself.

How should this be tested?

This will be verified when CI runs on any PR that touches API v2 files (which triggers the "Check API v2 breaking changes" workflow). The workflow should now pass instead of failing with TypeScript module resolution errors.

Checklist

  • My code follows the style guidelines of this project
  • I have checked if my changes generate no new warnings

Human Review Checklist

  • Verify the build step matches what other API v2 workflows use (e2e-api-v2.yml, api-v2-unit-tests.yml)
  • Confirm the set of packages being built is correct and complete

Link to Devin run: https://app.devin.ai/sessions/f7c710a65b90495a89c321afb8dc2f65
Requested by: Rajiv (@Ryukemeister)

@devin-ai-integration
Copy link
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

@Ryukemeister Ryukemeister marked this pull request as ready for review January 16, 2026 19:06
@Ryukemeister Ryukemeister requested a review from a team as a code owner January 16, 2026 19:06
@graphite-app graphite-app bot added core area: core, team members only consumer labels Jan 16, 2026
@graphite-app graphite-app bot requested a review from a team January 16, 2026 19:06
@Ryukemeister Ryukemeister added ready-for-e2e and removed core area: core, team members only consumer labels Jan 16, 2026
Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

@Ryukemeister Ryukemeister merged commit b7c497f into main Jan 16, 2026
84 of 86 checks passed
@Ryukemeister Ryukemeister deleted the devin/fix-api-v2-breaking-changes-workflow-1768590292 branch January 16, 2026 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants