feat: allow email invites in team event-type assignment #26957
+164
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update CheckedTeamSelect to use CreatableSelect for email input - Add email validation and comma-separated email parsing - Add isEmailInvite and email fields to Host and CheckedSelectOption types - Pass allowEmailInvites prop through AddMembersWithSwitch - Enable email invites in EventTeamAssignmentTab for both fixed and round-robin hosts Closes calcom#13532
github-actions
bot
added
$20
community
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx">
<violation number="1" location="apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx:231">
P2: Email invite hosts all use userId=0, but updatedHosts matches only on userId, causing later email invites to reuse the first invite’s groupId/scheduleId</violation>
</file>
<file name="apps/web/modules/event-types/components/CheckedTeamSelect.tsx">
<violation number="1" location="apps/web/modules/event-types/components/CheckedTeamSelect.tsx:109">
P2: Duplicate emails in a single comma-separated input aren’t deduped, allowing identical invite entries to be added in one create action.</violation>
<violation number="2" location="apps/web/modules/event-types/components/CheckedTeamSelect.tsx:148">
P1: React-select props from callers (e.g., isOptionDisabled, controlShouldRenderValue) are no longer forwarded, causing regressions like allowing disabled options to be selected.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
apps/web/modules/event-types/components/tabs/assignment/EventTeamAssignmentTab.tsx
Show resolved
Hide resolved
- Forward caller props to CreatableSelect (isOptionDisabled, etc.) - Dedupe emails in comma-separated input - Fix userId=0 collision by matching email invites by email
Author
|
@cubic-dev-ai please re-review |
Contributor
@yuvrajangadsingh I have started the AI code review. It will take a few minutes to complete. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Changes
CheckedTeamSelectto useCreatableSelectfor email inputisEmailInviteandemailfields toHostandCheckedSelectOptiontypesallowEmailInvitesprop throughAddMembersWithSwitchcomponent chainEventTeamAssignmentTabfor both fixed and round-robin hostsTest plan
Closes #13532
/claim #13532