ci: add separate typecheck and lint workflows for companion #26961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a new companion-typecheck.yml workflow that runs TypeScript type checking for the companion app. This would have caught the missing useEffect import issue in PR #26931. Changes: - Add new companion-typecheck.yml workflow file - Update pr.yml to call the new workflow when companion files change - Add typecheck-companion to the required jobs list Co-Authored-By: [email protected] <[email protected]>
anikdhabal
force-pushed
the
devin/1768666328-add-companion-typecheck
branch
from
f538b7c to
00fae93
Compare
anikdhabal
changed the title
Contributor
Author
|
Manually run it here:- https://github.com/calcom/cal.com/actions/runs/21097724937/job/60677483402 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
|
|
||
| - name: Run lint | ||
| working-directory: companion | ||
| run: bun run lint:all |
Member
There was a problem hiding this comment.
note: the bun run lint:all command runs both Biome and ESLint. We kept ESLint because it enforces the React compiler linting rules.
Do you think this CI job will work as expected?
|
|
||
| - name: Type check | ||
| working-directory: companion | ||
| run: bun run typecheck |
Member
There was a problem hiding this comment.
could we please use bun run typecheck:all command here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add separate typecheck and lint workflows for companion. This would have caught the missing
useEffectimport issue in PR #26931 before it was merged.Background: PR #26931 was merged with
useEffectbeing used but not imported inAvailabilityDetailScreen.tsxandAvailabilityDetailScreen.ios.tsx. The companion CI only ran builds (expo exportandext:build) which don't catch TypeScript errors the same waytsc --noEmitdoes.