-
Notifications
You must be signed in to change notification settings - Fork 11.6k
fix: character limit & textarea overlaps #26963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jagadish Madavalkar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/public/static/locales/en/common.json">
<violation number="1" location="apps/web/public/static/locales/en/common.json:1685">
P2: Bio helper text shows a hard-coded "0/256 characters" that never updates, giving an incorrect character count after typing.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| @@ -1746,7 +1682,8 @@ | |||
| "finish_and_start": "Finish setup and get started", | |||
| "user_has_no_bio": "This user has not added a bio yet.", | |||
| "bio": "Bio", | |||
| "delete_account_modal_title": "Delete account", | |||
| "tip_onboarding": "0/256 characters", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: Bio helper text shows a hard-coded "0/256 characters" that never updates, giving an incorrect character count after typing.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/web/public/static/locales/en/common.json, line 1685:
<comment>Bio helper text shows a hard-coded "0/256 characters" that never updates, giving an incorrect character count after typing.</comment>
<file context>
@@ -1682,6 +1682,7 @@
"finish_and_start": "Finish setup and get started",
"user_has_no_bio": "This user has not added a bio yet.",
"bio": "Bio",
+ "tip_onboarding": "0/256 characters",
"delete_account_modal_title": "Delete Account",
"confirm_delete_account_modal": "Are you sure you want to delete your {{appName}} account?",
</file context>
|
Hi Reviewers, currently the "tip_onboarding" is updated only in en(English) language. Let me know any better way to update this in all languages. Also for any other changes required to merge this PR. Thanks |
What does this PR do?
Visual Demo (For contributors especially)
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Mandatory Tasks (DO NOT REMOVE)
Checklist
Summary by cubic
Fixes the bio textarea overlap in onboarding and adds a 256-character limit with a small tip. Addresses #26903 and Linear CAL-7075.
Bug Fixes
New Features
Written for commit 0b6135f. Summary will update on new commits.