perf: timezone select component #26980
Open
+69
−49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graphite-app
bot
added
enterprise
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/features/components/timezone-select/TimezoneSelect.tsx">
<violation number="1" location="packages/features/components/timezone-select/TimezoneSelect.tsx:157">
P2: Inline `styles` object is recreated on every render, which defeats memoization and can cause unnecessary re-renders in react-select. Keep the styles object memoized so its reference is stable across renders.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Contributor
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
Udit-takkar
commented
Jan 18, 2026
Comment on lines
-114
to
-117
| timezones={{ | ||
| ...(props.data ? addTimezonesToDropdown(data) : {}), | ||
| ...(isWebTimezoneSelect ? addTimezonesToDropdown(additionalTimezones) : {}), | ||
| }} |
Contributor
Author
There was a problem hiding this comment.
This would have created new object on every render
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/features/components/timezone-select/TimezoneSelect.tsx">
<violation number="1" location="packages/features/components/timezone-select/TimezoneSelect.tsx:88">
P2: Memoizing `data` by `props.data?.length` can return stale timezone options when the array contents change but length doesn’t. Depend on the full `props.data` reference (or remove memoization) so updates propagate correctly.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/features/components/timezone-select/TimezoneSelect.tsx
Outdated
Show resolved
Hide resolved
Contributor
Devin AI is addressing Cubic AI's review feedbackA Devin session has been created to address the issues identified by Cubic AI. |
The useMemo dependency on props.data?.length could return stale timezone options when the array contents change but the length stays the same. Using the full props.data reference ensures updates propagate correctly. Fix identified by Cubic AI (confidence 9/10) Co-Authored-By: unknown <>
Contributor
There was a problem hiding this comment.
1 issue found across 1 file (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/features/components/timezone-select/TimezoneSelect.tsx">
<violation number="1" location="packages/features/components/timezone-select/TimezoneSelect.tsx:88">
P2: Memoizing `data` only on `props.data?.length` can leave stale timezone options when the array contents change but the length doesn’t. Depend on `props.data` itself (or a stable hash) so updates propagate correctly.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
packages/features/components/timezone-select/TimezoneSelect.tsx
Outdated
Show resolved
Hide resolved
Contributor
Devin AI is addressing Cubic AI's review feedbackNew feedback has been sent to the existing Devin session. ✅ Pushed commit |
The useMemo dependency on props.data?.length could return stale timezone options when the array contents change but the length stays the same. Using the full props.data reference ensures updates propagate correctly. Fix identified by Cubic AI (confidence 9/10) Co-Authored-By: unknown <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Saw this
vscomponent in Profile which I think is react-select's internal componentsMandatory Tasks (DO NOT REMOVE)
How should this be tested?
Summary by cubic
Optimized the timezone select to reduce re-renders and speed up search and typing. Also fixed stale options by correcting memoization dependencies.
Written for commit 7aac94d. Summary will update on new commits.