feat(booking-filters): no-show filter added#27866
Conversation
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="apps/web/modules/bookings/hooks/useFacetedUniqueValues.ts">
<violation number="1" location="apps/web/modules/bookings/hooks/useFacetedUniqueValues.ts:62">
P2: `t` from `useLocale` is used inside the `useCallback` callback but is missing from the dependency array. If the locale changes, this callback will keep using the old translator and return a stale label.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
was wondering I should add indexing or not in the boolean field. Took the decision of not adding by looking at this. Please LMK if you think it's needed. |
There was a problem hiding this comment.
@bandhan-majumder added comments!
also can you add/update relevant tests.
|
Adding the tests. Once done, I will make it ready for review edit: added the tests, updated description |
|
@romitg2 I have started the AI code review. It will take a few minutes to complete. |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
Devin AI is resolving merge conflictsThis PR has merge conflicts with the Devin will:
If you prefer to resolve conflicts manually, you can close the Devin session and handle it yourself. |
Automated Merge Conflict Resolution - Failed to PushI successfully resolved the merge conflicts locally (only 1 conflict in Conflict resolution details:
Push failure reason: The To resolve manually: git fetch upstream main
git merge upstream/main
# Resolve the single conflict in apps/web/modules/bookings/components/BookingListContainer.tsx:
# - Use: const { limit, offset, isValidatorPending } = useDataTable(); (remove setPageIndex)
# - Use: const { eventTypeIds, teamIds, userIds, dateRange, attendeeName, attendeeEmail, bookingUid, noShow } = (keep noShow)
git add . && git commit
git push |
romitg2
left a comment
There was a problem hiding this comment.
@bandhan-majumder overall PR looks good, but ux of adding no-show filter could be improved. would it be possible to add just no-show filter without additionally clicking yes checkbox?
|
@romitg2 I agree. Made the changes. attached the update ui below (and in the PR description)
|
|
@romitg2 I am not sure if the test failure was related to the changes. I have updated one constant mock which was causing noise, should pass now. If this fails again, I will reinvestigate the issue |

What does this PR do?
Visual Demo (For contributors especially)
Video Demo (if applicable):
Screencast.From.2026-02-22.22-36-32.mp4
Image Demo (if applicable):
Tests
fail why they are expected to fail
Passes when expected to pass
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Checklist
Summary by cubic
Adds a “No show” filter to the bookings list and API to quickly find bookings where the host or any attendee was a no‑show. Implements Linear CAL-7184 and localizes the filter.
New Features
Bug Fixes
Written for commit 5f75c6a. Summary will update on new commits.