fix: add @calcom/api-v2 to dev:api script#28738
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated monorepo dev scripts to include the 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Tip 💬 Introducing Slack Agent: The best way for teams to turn conversations into code.Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.
Built for teams:
One agent for your entire SDLC. Right inside Slack. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
|
Thanks for the ping. This PR is ready from my side and still relevant. Please let me know if you’d like any changes, and I can update it promptly. |
621407c to
79dce8d
Compare
|
@romitg2 rebased onto latest |
The dev:api script starts the web app, API proxy, and API v1 for local development, but omits API v2. This means developers working on API v2 need to start it separately or use a different script. Add --filter="@calcom/api-v2" to the dev:api turbo command so that both API versions start together during local development. Fixes calcom#28736
79dce8d to
9d7ca1c
Compare
- API_V1_PORT defaults to 3000 (matching web's default) - API_V2_PORT defaults to 5555 (matching api-v2's default) - API_PROXY_PORT defaults to 3002 - Fixed route order: /v2 before / to prevent catch-all
|
Thanks @romitg2 — really nice catch on the middleware ordering. With Glad to keep this moving — let me know if there's anything you'd like me to do on my side. |
|
Quick status update: the CLA is now signed (see the CLAassistant comment above — |
7b0eb06 to
e4116e1
Compare
|
This PR has been marked as stale due to inactivity. If you're still working on it or need any help, please let us know or update the PR to keep it active. |
Problem
The
dev:apiscript in the rootpackage.jsonstarts the web app, API proxy, and API v1 via Turborepo filters, but does not include@calcom/api-v2. Developers working on API v2 need to start it separately.Solution
Add
--filter="@calcom/api-v2"to thedev:apiturbo command:This ensures both API v1 and v2 start together during local development.
Fixes #28736