Skip to content

fix(api): remove .ics suffix requirement from ICS feed URL validator #29507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NamanYadav11 wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −9
Open

fix(api): remove .ics suffix requirement from ICS feed URL validator #29507

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions apps/api/v2/src/platform/calendars/input/create-ics.input.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,27 +15,24 @@ export class IsICSUrlConstraint implements ValidatorConstraintInterface {
validate(url: unknown) {
if (typeof url !== "string") return false;

// Check if it's a valid URL and ends with .ics
// Check if it's a valid http/https URL — RFC 5545 imposes no .ics suffix requirement
try {
const urlObject = new URL(url);
return (
(urlObject.protocol === "http:" || urlObject.protocol === "https:") &&
urlObject.pathname.endsWith(".ics")
);
} catch (error) {
return urlObject.protocol === "http:" || urlObject.protocol === "https:";
} catch {
return false;
}
}

defaultMessage() {
return "The URL must be a valid ICS URL (ending with .ics)";
return "The URL must be a valid http or https URL";
}
}

export class CreateIcsFeedInputDto {
@ApiProperty({
example: ["https://cal.com/ics/feed.ics", "http://cal.com/ics/feed.ics"],
description: "An array of ICS URLs",
example: ["https://cal.com/ics/feed.ics", "https://calendar.example.com/feed?format=ics"],
description: "An array of ICS feed URLs (http or https)",
type: "array",
items: {
type: "string",
Expand Down
Loading