Skip to content

fix(security): prevent team webhook IDOR by enforcing ADMIN/OWNER role check (#29982) #30009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jihadMo wants to merge 1 commit into
base: main
Choose a base branch
from
+82 −69
Open

fix(security): prevent team webhook IDOR by enforcing ADMIN/OWNER role check (#29982) #30009

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
151 changes: 82 additions & 69 deletions packages/trpc/server/routers/viewer/webhook/util.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,69 +1,82 @@
import { prisma } from "@calcom/prisma";

import { TRPCError } from "@trpc/server";

import authedProcedure from "../../../procedures/authedProcedure";
import { webhookIdAndEventTypeIdSchema } from "./types";

export const createWebhookProcedure = () => {
return authedProcedure.input(webhookIdAndEventTypeIdSchema.optional()).use(async ({ ctx, input, next }) => {
if (!input) return next();

const { id, webhookId, eventTypeId } = input;
const lookupId = id || webhookId;

if (lookupId) {
// Check if user is authorized to edit webhook
const webhook = await prisma.webhook.findUnique({
where: { id: lookupId },
select: {
id: true,
userId: true,
eventTypeId: true,
},
});

if (!webhook) {
throw new TRPCError({ code: "NOT_FOUND" });
}

if (eventTypeId && eventTypeId !== webhook.eventTypeId) {
throw new TRPCError({ code: "UNAUTHORIZED" });
}

if (webhook.eventTypeId) {
const eventType = await prisma.eventType.findUnique({
where: { id: webhook.eventTypeId },
select: { id: true, userId: true },
});

if (!eventType) {
throw new TRPCError({ code: "NOT_FOUND" });
}

if (eventType.userId !== ctx.user.id) {
throw new TRPCError({ code: "FORBIDDEN" });
}
} else if (webhook.userId && webhook.userId !== ctx.user.id) {
throw new TRPCError({ code: "FORBIDDEN" });
}
} else if (eventTypeId) {
const eventType = await prisma.eventType.findUnique({
where: { id: eventTypeId },
select: { id: true, userId: true },
});

if (!eventType) {
throw new TRPCError({ code: "NOT_FOUND" });
}

if (eventType.userId !== ctx.user.id) {
throw new TRPCError({ code: "FORBIDDEN" });
}
}

return next();
});
};

export const webhookProcedure = createWebhookProcedure();
import { prisma } from "@calcom/prisma";

import { TRPCError } from "@trpc/server";

import authedProcedure from "../../../procedures/authedProcedure";
import { webhookIdAndEventTypeIdSchema } from "./types";

export const createWebhookProcedure = () => {
return authedProcedure.input(webhookIdAndEventTypeIdSchema.optional()).use(async ({ ctx, input, next }) => {
if (!input) return next();

const { id, webhookId, eventTypeId } = input;
const lookupId = id || webhookId;

if (lookupId) {
// Check if user is authorized to edit webhook
const webhook = await prisma.webhook.findUnique({
where: { id: lookupId },
select: {
id: true,
userId: true,
teamId: true,
eventTypeId: true,
},
});

if (!webhook) {
throw new TRPCError({ code: "NOT_FOUND" });
}

if (eventTypeId && eventTypeId !== webhook.eventTypeId) {
throw new TRPCError({ code: "UNAUTHORIZED" });
}

if (webhook.eventTypeId) {
const eventType = await prisma.eventType.findUnique({
where: { id: webhook.eventTypeId },
select: { id: true, userId: true },
});

if (!eventType) {
throw new TRPCError({ code: "NOT_FOUND" });
}

if (eventType.userId !== ctx.user.id) {
throw new TRPCError({ code: "FORBIDDEN" });
}
} else if (webhook.teamId) {
const membership = await prisma.membership.findFirst({
where: {
teamId: webhook.teamId,
userId: ctx.user.id,
accepted: true,
role: { in: ["ADMIN", "OWNER"] },
},
});
if (!membership) {
throw new TRPCError({ code: "FORBIDDEN" });
}
} else if (webhook.userId && webhook.userId !== ctx.user.id) {
throw new TRPCError({ code: "FORBIDDEN" });
}
} else if (eventTypeId) {
const eventType = await prisma.eventType.findUnique({
where: { id: eventTypeId },
select: { id: true, userId: true },
});

if (!eventType) {
throw new TRPCError({ code: "NOT_FOUND" });
}

if (eventType.userId !== ctx.user.id) {
throw new TRPCError({ code: "FORBIDDEN" });
}
}

return next();
});
};

export const webhookProcedure = createWebhookProcedure();
Loading