Fix: stroke/fill controls should not restyle imported icons - #98
Merged
Conversation
Applying a stroke/fill to an imported SVG logo recoloured all its paths into a single-colour blob. Treat a non-arrow group as an icon: the panel now hides the Stroke/Fill/Width/Style controls for a selected icon (shows an 'Icon' hint + the Layer controls), and applyToActive skips icons inside a multi-selection so a colour change on a mixed selection recolours the shapes but leaves logos intact. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Deploying whiteboard with
|
| Latest commit: |
2671b4e
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://745fbcb9.whiteboard-988.pages.dev |
| Branch Preview URL: | https://fix-icons-not-styleable.whiteboard-988.pages.dev |
Double-chevron icons (all the way) vs single-chevron (one step) plus explicit tooltips, so the one-step vs jump-to-edge reorder actions are distinguishable at a glance. No change to reorder logic. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Bring forward / send backward now pass fabric's intersecting flag, so they only move a shape relative to objects it actually overlaps. A shape already in front of everything it touches no longer keeps climbing past unrelated shapes, so it can't accumulate meaningless forward moves that then require an equal number of backward clicks to undo. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
applyToActiveskips icons inside a multi-selection, so a color change on a mixed selection recolors the shapes but leaves logos untouched.isIcon), so arrows still restyle normally and shapes/text are unaffected.Why
Reported: applying a stroke/fill to a dropped logo overwrote all its paths and flattened it into a single-color blob (a red Redis logo turned into a red blob).
Test plan (in-browser)
[icon + rectangle]→ apply green stroke → the rectangle turns green, the logo keeps its real colors (#912626/#c6302b/#fff/#621b1c).Note
A "single-path" logo (rare) is a bare
fabric.Path, not a group, so it isn't caught byisIconand would still accept a fill (same as a freehand stroke). Not worth a persistent per-object marker for now; can revisit if it comes up.