Skip to content

Conversation

@calderast
Copy link
Owner

@calderast calderast commented Oct 17, 2025

Resolves #177 and updates tests to reflect the change

@calderast calderast self-assigned this Oct 17, 2025
@calderast calderast added bug Something isn't working ephys All things related to electrophysiology processing high-priority Do now! This is blocking someone's progress and/or is essential for the functioning of the pipeline labels Oct 17, 2025
Copy link
Collaborator

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test to check the mapping is correct in the future

@calderast calderast requested a review from rly October 17, 2025 20:25
Copy link
Collaborator

@rly rly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@calderast calderast merged commit 7d3ab8c into main Oct 17, 2025
7 checks passed
@calderast calderast deleted the fix-electrode-mapping branch October 17, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ephys All things related to electrophysiology processing high-priority Do now! This is blocking someone's progress and/or is essential for the functioning of the pipeline

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix ordering of electrode_table_region so the correct row of the electrode table is matched to the correct trace

3 participants