Fix error detecting version and testing workflow #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rly
changed the title
Collaborator
Author
|
The GitHub Action workflow is running correctly now. The tests are failing because of the updates to the ephys tests and channel map. @calderast I suggest you squash and merge these commits so they don't clutter the commit history, but up to you. |
calderast
approved these changes
Dec 19, 2024
Owner
calderast
left a comment
calderast
left a comment
There was a problem hiding this comment.
looks good! We'll sort out the failing tests when we fix the channel maps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest run has an error getting the version from source
vcs. Fixing that resulted in errors finding the test data and the tests. This PR resolves those issues.