-
Notifications
You must be signed in to change notification settings - Fork 8
Script to Update API version #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
} | ||
|
||
# Read xml and assign Manifest API value | ||
while read_package; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why even bother reading the current versions and comparing them with the latest?
Seems much simpler to just blind write the newest version every time, and the outcome is effectively the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
less editing of the files was my thought.
- Catching up with master to avoid conflicts and for testing
@ChuckJonas seems like a perfect time to merge this and package it up since our image is out of date. I can merge but am not sure how to package it for npm ( I think you have a specific user/pwd for that?).
|
@fishygeek91 i'd love to broaden out pushing updates to our npm projects. perhaps you could work with charlie to set things up? key goals, reducing charlie bus factor, easy management of team members who can push items, and the ability to scope package visibility to public or just team members. i know npm has "teams" and "organizations" but I'm not sure if they're paid things, it's probably worth it at low rates. |
Script retrieves the latest version from the source org and updates the project manifest and sfdx-project json file.
Testing took a long time as the jq and sed tools were different for the CI shell in bitbucket, and I had to find some work arounds for each.
@ChuckJonas @ralphcallaway if you have any suggestions for improvements, I'm all ears