Skip to content

Script to Update API version #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

fishygeek91
Copy link
Collaborator

Script retrieves the latest version from the source org and updates the project manifest and sfdx-project json file.

Testing took a long time as the jq and sed tools were different for the CI shell in bitbucket, and I had to find some work arounds for each.

@ChuckJonas @ralphcallaway if you have any suggestions for improvements, I'm all ears

@fishygeek91 fishygeek91 self-assigned this Aug 12, 2021
}

# Read xml and assign Manifest API value
while read_package; do
Copy link
Collaborator

@ChuckJonas ChuckJonas Aug 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why even bother reading the current versions and comparing them with the latest?

Seems much simpler to just blind write the newest version every time, and the outcome is effectively the same.

Copy link
Collaborator Author

@fishygeek91 fishygeek91 Aug 16, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less editing of the files was my thought.

@trevoryager-callaway trevoryager-callaway linked an issue Sep 9, 2021 that may be closed by this pull request
Dustin Kovac added 3 commits November 30, 2021 15:07
- Catching up with master to avoid conflicts and for testing
@fishygeek91
Copy link
Collaborator Author

@ChuckJonas seems like a perfect time to merge this and package it up since our image is out of date. I can merge but am not sure how to package it for npm ( I think you have a specific user/pwd for that?).

  • I bumped the version
  • Merged master since this was stale
  • Also bumped image and tested in my "fishing-adventures" training project

@ralphcallaway
Copy link
Collaborator

@fishygeek91 i'd love to broaden out pushing updates to our npm projects. perhaps you could work with charlie to set things up?

key goals, reducing charlie bus factor, easy management of team members who can push items, and the ability to scope package visibility to public or just team members.

i know npm has "teams" and "organizations" but I'm not sure if they're paid things, it's probably worth it at low rates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keep API Version Up to Date
3 participants