-
Notifications
You must be signed in to change notification settings - Fork 0
Feature full rules #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
@sjpfenninger the module is (for now) feature-complete. Brief summary: Necessary inputs
Configuration
Testing Missing stuff (not for this PR)
|
for more information, see https://pre-commit.ci
sjpfenninger
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It generally looks great!
There is quite a lot going on, so a high-level overview of the steps, and the data sources used, in docs/index.md is really required.
I did not go very deep into code for imputing and the special treatment of solar, but the results that I looked at are credible.
workflow/envs/shapes.yaml
Outdated
| - xlrd = 2.0.1 | ||
| - pip = 25.1.1 | ||
| - pip: | ||
| - git+https://github.com/irm-codebase/gregor.git@fix-memory-explosion#egg=gregor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If gregor needs to be dependency across multiple modules, it should become part of the org. Otherwise, this will be problematic again and again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed. I'm just waiting for the latest release, to use the official version.
for more information, see https://pre-commit.ci
|
@sjpfenninger I've fixed most review comments. Two things are still missing.
|
Fixes #1
Summary of changes in this pull request
Reviewer checklist
INTERFACE.yamlis up-to-date with all relevant user resources and results.