Skip to content

refactor(interaction): resolve the CapturedSnapshot name collision #1371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Jul 23, 2026
Merged

refactor(interaction): resolve the CapturedSnapshot name collision #1371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/commands/interaction/runtime/resolution.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export type InteractionAction =
| 'rotate'
| 'transform';

export type CapturedSnapshot = {
export type InteractionSnapshot = {
snapshot: SnapshotState;
};

Expand Down Expand Up @@ -533,7 +533,7 @@ export async function captureInteractionSnapshot(
runtime: AgentDeviceRuntime,
options: CommandContext,
interactiveOnly: boolean,
): Promise<CapturedSnapshot> {
): Promise<InteractionSnapshot> {
if (!runtime.backend.captureSnapshot) {
throw new AppError('UNSUPPORTED_OPERATION', 'snapshot is not supported by this backend');
}
Expand Down Expand Up @@ -584,7 +584,7 @@ async function resolveSnapshotForRef(
runtime: AgentDeviceRuntime,
options: CommandContext,
target: Extract<InteractionTarget, { kind: 'ref' }>,
): Promise<CapturedSnapshot & { resolved: ResolvedRefNode }> {
): Promise<InteractionSnapshot & { resolved: ResolvedRefNode }> {
const { session, snapshot: frameTree } = await requireSnapshotSession(runtime, options.session);

const fallbackLabel = target.fallbackLabel ?? '';
Expand Down Expand Up @@ -626,7 +626,7 @@ function reconcileFreshObservation(params: {
target: Extract<InteractionTarget, { kind: 'ref' }>;
fallbackLabel: string;
authorized: ResolvedRefNode;
}): CapturedSnapshot & { resolved: ResolvedRefNode } {
}): InteractionSnapshot & { resolved: ResolvedRefNode } {
const { session, frameTree, target, fallbackLabel, authorized } = params;
const observation = session.snapshot;
if (!observation || observation === frameTree) {
Expand Down
Loading