fix(web): preserve the backend ref so snapshot refs match actionable refs - #2283
Conversation
…refs
The web/agent-browser backend mints refs in tree order and skips
non-interactive nodes, so its `@eN` refs are not dense. agent-device was
dropping that ref in `normalizeAgentBrowserSnapshot` and then re-minting a
dense positional `e${index+1}` in `attachRefs`. The ref an agent reads off
the snapshot (dense, positional) therefore did not equal the ref the backend
resolves on the next action (tree-ordered). On the ShopDemo login screen the
username textbox displayed as one ref while the backend's ref for the same
position pointed at the passcode field, so `fill @e3` landed in the wrong
input.
Preserve the backend ref on each web node and make `attachRefs` keep a
node's existing `ref` when present, falling back to dense numbering for
backends that do not mint refs (iOS/Android/maestro are unaffected).
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed files
|
|
Review at exact head f848b6f found one actionable regression-proof gap. The new tests prove the agent-browser normalizer retains |
|
Addressed the regression-proof and live-evidence request in
|
|
Sentinel reconciliation at bb43f00: the non-dense production-route regression and recorded after-fix browser evidence address the previous review requests; no remaining code finding in this diff. CI is now blocked: iOS run 33984867542 failed smoke:automation-input while waiting for Agent Device Tester. Diagnostics report wait_runner_restart_exhausted, readableCaptures=0, runner_connect_failed_before_command_send (10s budget; about 23.8s elapsed). This is a runner connection/restart failure, not evidence of a web-ref assertion failure; a flake is not proven. Investigate/rerun that lane before merge. No readiness label applied. |
|
* origin/main: perf: bundle runtime dependencies and report full install size (#2310) ci: avoid unrelated Apple runner cache invalidation (#2303) fix(web): preserve the backend ref so snapshot refs match actionable refs (#2283) test(daemon): session-open-url-prewarm through the request seam (#2304) test(daemon): session-devices-batch-runtime through the request seam (#2305) chore(gates): layering baselines ratchet against merge-base (#2299) test(daemon): one typed conformance helper for the daemon runtime suites (#2298) chore(layering): derive the contracts export inventory from package.json (#2297) perf: bundle tar-stream to reduce install footprint (#2286) docs: simplify agent context and resolve conflicting guidance (#2287) refactor(cli): let help resolve command aliases itself and retire R12 (#2293)
* origin/main: perf: bundle runtime dependencies and report full install size (#2310) ci: avoid unrelated Apple runner cache invalidation (#2303) fix(web): preserve the backend ref so snapshot refs match actionable refs (#2283) test(daemon): session-open-url-prewarm through the request seam (#2304) test(daemon): session-devices-batch-runtime through the request seam (#2305) chore(gates): layering baselines ratchet against merge-base (#2299) test(daemon): one typed conformance helper for the daemon runtime suites (#2298) chore(layering): derive the contracts export inventory from package.json (#2297) perf: bundle tar-stream to reduce install footprint (#2286) docs: simplify agent context and resolve conflicting guidance (#2287) refactor(cli): let help resolve command aliases itself and retire R12 (#2293) refactor(commands): retire the navigation-only type projection (#2294) feat(runtime): route managed leases through contained transports (#2285) refactor(contracts): build unavailable runtime facts once (#2291) refactor(cli): derive the common flag readers from the common-field table (#2292) feat(daemon): add managed allocation operation journal (#2284)
* origin/main: perf: bundle runtime dependencies and report full install size (#2310) ci: avoid unrelated Apple runner cache invalidation (#2303) fix(web): preserve the backend ref so snapshot refs match actionable refs (#2283) test(daemon): session-open-url-prewarm through the request seam (#2304) test(daemon): session-devices-batch-runtime through the request seam (#2305) chore(gates): layering baselines ratchet against merge-base (#2299) test(daemon): one typed conformance helper for the daemon runtime suites (#2298) chore(layering): derive the contracts export inventory from package.json (#2297) perf: bundle tar-stream to reduce install footprint (#2286)
1 participant
Summary
Preserve agent-browser refs through snapshot normalization and storage so web actions target the element shown in the snapshot. Backends without refs retain positional numbering.
For a snapshot exposing Username
e2, Passcodee3, and Sign ine4,fill @e2 Adatargets Username andclick @e4targets Sign in.Six files changed. Adds production-route regression coverage through the public browser provider, request router, stored snapshot refs, and backend fill/click commands.
Validation
Tested commit:
bb43f00ddb.pnpm check:affected --run: passed (730 files, 5,585 tests). First run hit a session-runtime Apple cleanup process-guard failure; the isolated file and full rerun passed.attachRefspreservation independently fails with positionale1/e2/e3replacinge2/e3/e4.e2, Passcodee3, Sign ine4;fill @e2 Adaproduced DOM values#login-username="Ada",#login-password=""; after a fresh snapshot,click @e4fired Sign in. Session closed successfully. This live fixture included a heading ate1; the automated route scenario supplies the non-dense case.