Skip to content

feat: admit managed requests within lease authority - #2319

Merged
thymikee merged 3 commits into
feat/managed-automation-delegationfrom
feat/managed-request-admission
Sep 6, 2026
Merged

feat: admit managed requests within lease authority#2319
thymikee merged 3 commits into
feat/managed-automation-delegationfrom
feat/managed-request-admission

Conversation

@thymikee

@thymikee thymikee commented Sep 5, 2026

Copy link
Copy Markdown
Member

Summary

Exact managed requests resolve matching lease authority, admit the allocator-held claim, and confirm the command-plus-teardown horizon before native binding. Readiness activates after cleanup adoption and operation projection. Reviewed operations execute inside lease admission. Request disposal cancels pending admissions and revokes captured operations before cleanup, preserving shared renewal and late-binding cleanup ownership.

Based on published #2312 9195cb7b37ba0af09a1c6b7c3b58e2a0c1545293, rooted in main snapshot 80997b6bf1dda30ca57d74dc42036f6b447e16ad. Seven files, 616 gross lines. ADR 0021 documents the configured seam; skills are unchanged. Unconfigured managed requests remain refused. Publication/recovery coordination and live Host/Simlock acceptance remain future work.

Validation

Head 9d6b3a784dfdd0648f4c05386101c63f2fb30091:

  • pnpm check:affected --run: all runnable gates pass; 4,230 affected tests across 550 files.
  • Focused instrumented suite: 31 tests pass, including all 16 provider-integration scenarios. The admission helper has 100% line/branch coverage; both owning modules total 98.61% lines and 92.5% branches. Integration and Coverage select the relocated scenarios.
  • All 420 exact-parent closure checks pass; typecheck passes.
  • Independent adversarial review: READY. Observed red proofs cover mismatched authority before renewal, cancellation during renewal and after adoption, immediate revocation before cleanup, and real dispatch inside admission.

Exact-head CI now passes, including Coverage and Integration. Android, iOS, Linux, macOS smoke and Size also pass. #2319 request-admission validation is satisfied. The future publication/recovery integration PR owns an end-to-end live validator on iOS and Android: real allocation → open → operation → fencing/cleanup → release, exercising the production path without a separate test-only path. No PR exists for that piece yet.

@github-actions

github-actions Bot commented Sep 5, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
Installed (including dependencies) 4.48 MB 4.49 MB +1.8 kB
Package (unpacked) 4.48 MB 4.49 MB +1.8 kB
Package (download) 1.33 MB 1.33 MB +649 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 27.8 ms 26.7 ms -1.0 ms
CLI --help 82.8 ms 78.4 ms -4.4 ms

@thymikee

thymikee commented Sep 5, 2026

Copy link
Copy Markdown
Member Author

Sentinel at 9d6b3a7 against 9195cb7: clean coordinator + independent Terra/high code review. Matching lease authority and allocator-held claim precede native bind; operations execute inside admission; readiness activates after adoption/projection; disposal revokes pending/captured work before cleanup. Regression scenarios exercise the composed dispatch and cancellation/fence boundaries. Exact-head CI, including Coverage and Integration, is green; size is +1.8 kB. This is deliberately a configured seam, not production Host activation: the publication/recovery coordinator and live Host/Simlock acceptance are still absent. Evidence-pending, not merge-ready; provide live allocator-owned request/operation/teardown evidence and land the prerequisite stack, including resolving #2308 failing iOS CI. No readiness label, fixes or merge.

@thymikee

thymikee commented Sep 6, 2026

Copy link
Copy Markdown
Member Author

Sequential #2319 review pass after #2311 and #2312, at unchanged head 9d6b3a784dfdd0648f4c05386101c63f2fb30091 and exact published parent 9195cb7b37ba0af09a1c6b7c3b58e2a0c1545293. All three commits are range-diff identical; no rebase or push is needed.

Feedback mapping:

Validation ownership, as clarified by the maintainer:

Independent fresh read-only review: READY, no actionable findings. Existing exact-head local evidence remains valid: all runnable affected gates passed, 4,230 tests / 550 files, plus 420 exact-parent closure checks and 31 focused instrumented tests. No source changes or repeated gate are needed for this ownership correction.

Updated the PR description and this response to reflect the correct validation scope. No code, repository docs, or skills changed. No merge performed.

@thymikee
thymikee merged commit 0bebbe8 into main Sep 6, 2026
18 checks passed
@thymikee
thymikee deleted the feat/managed-request-admission branch September 6, 2026 06:11
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-06 06:11 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant