feat: add ability to change padding between FAB group items #1435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @mmarkusik, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
Trancever
suggested changes
Nov 14, 2019
| /** | ||
| * Space between FAB group items | ||
| */ | ||
| itemMargin?: number; |
There was a problem hiding this comment.
Let's remove this prop and instead add wrapperStyle prop to the actions - line 30.
There was a problem hiding this comment.
Let's remove this prop and instead add
wrapperStyleprop to the actions - line 30.
|
Hello 👋, this pull request has been open for more than 2 months with no activity on it. If you think this is still necessary with the latest version, please comment and ping a maintainer to get this reviewed, otherwise it will be closed automatically in 7 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This pull requests introduces a feature proposed in Add ability to change padding between fab group children #1274
Test plan
FABExamplecomponentitemMarginwith numeric value to the renderedFAB.Groupcomponent