Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android bottom tabs crash fix when used with react-native-screens #4550

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: android bottom tabs crash fix when used with react-native-screens #4550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/components/BottomNavigation/BottomNavigation.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,7 +548,8 @@ const BottomNavigation = <Route extends BaseRoute>({
removeClippedSubviews={
// On iOS, set removeClippedSubviews to true only when not focused
// This is an workaround for a bug where the clipped view never re-appears
Platform.OS === 'ios' ? navigationState.index !== index : true
// On Android, it is disabled until https://github.com/software-mansion/react-native-screens/issues/2491 is fixed
Platform.OS === 'ios' ? navigationState.index !== index : false
}
>
<Animated.View
Expand Down
Loading