fix: android auto increment on new arch #691
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Fix android auto increment issued on new arch (See #683).
Added same check
if(fromUser)
that is present in the old architecture.react-native-slider/package/android/src/oldarch/java/com/reactnativecommunity/slider/ReactSliderManager.java
Lines 37 to 42 in e9084f6
Test Plan:
Used #683 as a template for bare react native project, to reproduce the issue and check if it is still present.