Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android auto increment on new arch #691

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Juozas-Petkelis
Copy link

Summary:

Fix android auto increment issued on new arch (See #683).

Added same check if(fromUser) that is present in the old architecture.

if(fromUser) {
reactContext.getNativeModule(UIManagerModule.class).getEventDispatcher().dispatchEvent(
new ReactSliderEvent(
seekbar.getId(),
slider.toRealProgress(progress), true));
}

Test Plan:

Used #683 as a template for bare react native project, to reproduce the issue and check if it is still present.

Before After
Before After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant