Skip to content

Escape bundle identifiers when creating Apple frameworks and allow passing --apple-bundle-identifier #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 4, 2025
Merged

Escape bundle identifiers when creating Apple frameworks and allow passing --apple-bundle-identifier #316

merged 2 commits into from
Nov 4, 2025
+79 −11

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Nov 4, 2025 •
edited
Loading

Fixes #313.

Merging this PR will:

  • Escape the library name before saving it to the Info.plist when creating Apple frameworks.
  • Allow passing --apple-bundle-identifier to control the bundle identifier of Apple frameworks created via ferric and cmake-rn.

@kraenhansen kraenhansen self-assigned this Nov 4, 2025
@kraenhansen kraenhansen added enhancement New feature or request Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) CMake RN Our `cmake` wrapping CLI Host 🏡 Our `react-native-node-api-modules` package Ferric 🦀 labels Nov 4, 2025
@kraenhansen kraenhansen mentioned this pull request Nov 4, 2025
Closed
@kraenhansen kraenhansen merged commit 61fff3f into main Nov 4, 2025
8 checks passed
@kraenhansen kraenhansen deleted the kh/escape-bundle-identifiers branch November 4, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@kraenhansen kraenhansen

Labels

Apple 🍎 Anything related to the Apple platform (iOS, macOS, Cocoapods, Xcode, XCFrameworks, etc.) CMake RN Our `cmake` wrapping CLI enhancement New feature or request Ferric 🦀 Host 🏡 Our `react-native-node-api-modules` package

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Escape the crate name when transforming it into a bundle identifier

2 participants

@kraenhansen