feat(create-app): download template from npm #10
Conversation
mdjastrzebski
force-pushed
the
feat/create-app/download-template-from-npm
branch
2 times, most recently
from
a6406a9 to
50ea4d7
Compare
mdjastrzebski
changed the title
mdjastrzebski
force-pushed
the
feat/create-app/download-template-from-npm
branch
2 times, most recently
from
839cdd5 to
63517f5
Compare
| } | ||
| }, | ||
| "test": { | ||
| "dependsOn": ["build"] |
There was a problem hiding this comment.
why tests depend on build? is this because of vite?
There was a problem hiding this comment.
because there are e2e tests, which invoke node packages/create-app/dist/... binary for create-app. Without build step this binary would not exist.
There was a problem hiding this comment.
Shouldn’t there be a separate job for unit and e2e tests then?
There was a problem hiding this comment.
it's all jest
There was a problem hiding this comment.
now vitest actually
| packageJson.version = '1.0.0'; | ||
| packageJson.private = true; | ||
|
|
||
| function walk(current: string): string[] { |
There was a problem hiding this comment.
where's this logic? we don't only need to rename stuff package.json. It's mostly about rewriting "HelloWorld" placeholder in native files and filenames
There was a problem hiding this comment.
restored previous edit template code
|
Let's rebase and merge 👍🏼 |
chore: refactor: tweaks chore: basic e2e tests chore: add build req to project chore: fix ci chore: fix ci chore: diagnose ci chore: fix ci chore: fix ci chore: fix ci refactor: improve tests refactor: improve test helpers chore: revert ci script changes chore: a chore: cleanup refactor: cleanup chore: cleanup chore: cleanup refactor: self code review chore: restore test target dep on build refactor: modify post copy template changes refactor: self code review refactor: self code review refactor: restore previous renaming code refactor: self code review
mdjastrzebski
force-pushed
the
feat/create-app/download-template-from-npm
branch
from
ee22f8f to
004c3dc
Compare
mdjastrzebski
changed the title
Summary
Supports following types of templates:
./../,/, orfile://).tgzfilesAlso performs some basic template-edition:
gitignoreto.gitignoreTest plan
Added e2e tests existing the app and checking some basic details like package name, etc