-
Notifications
You must be signed in to change notification settings - Fork 36
chore: migrate from CJS to ESM #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
commented
Oct 2, 2024
mdjastrzebski
requested changes
Oct 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've noticed some issues with the current state of the branch:
d.tsfiles are generated per source file, whileindex.jsseems to be bundled together. These should probably be the same, either per-file or bundled.- There is no
bin.jsincreate-app test-helpersis havingdistin top-level folder, whilecreate-apphas it's own inpackags/create-app. I think the second option is better if we want to run binaries, as we don't have to install deps indistthen.
e3d9756 to
3645000
Compare
|
@mdjastrzebski after migration to |
mdjastrzebski
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.



Summary
Migrates to ESM.
Test plan
pnpm buildshould produce build in ESM format.