feat(fingerprint): add support for customizing extraSources & ignorePaths
#198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
reviewed
Mar 9, 2025
thymikee
reviewed
Mar 9, 2025
thymikee
reviewed
Mar 9, 2025
packages/platform-apple-helpers/src/lib/commands/run/fetchCachedBuild.ts
Outdated
Show resolved
Hide resolved
szymonrybczak
force-pushed
the
feat/custom-sources
branch
from
730acc0 to
c3e564b
Compare
Pass project root to fetchCachedBuild in both Android and iOS platforms to ensure consistent path handling for cached builds.
Pass getFingerprintOptions from command level instead of re-running getConfig in fetchCachedBuild. This avoids expensive config traversal and plugin application on each build cache check.
Added basic test scenarios covering: single file processing, directory processing, non-existent paths handling, absolute paths handling
thymikee
reviewed
Mar 10, 2025
thymikee
reviewed
Mar 10, 2025
thymikee
approved these changes
Mar 12, 2025
thymikee
reviewed
Mar 12, 2025
| try { | ||
| const isGlobPattern = glob.isDynamicPattern(source); | ||
| if (isGlobPattern) { | ||
| const matches = await glob(source, { |
There was a problem hiding this comment.
Can we use glob.sync and make the processExtraSources function non async too? Sync fs access is usually faster
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some projects might want to include or exclude custom input sources when calculating fingerprint. This Pull Requests implements
fingerprintobject in config which includesextraSourcesandignorePathsproperties.ignorePathsby default accepts glob patterns which is not a case withextraSourcesso that's why we have to transform user-configured glob patterns to proper type which@expo/fingerprintaccepts so both properties accept the same format 👍Test plan
fingerprintconfiguration object inrnef.config.jsfingerprint --platform android