Skip to content

chore: don't require full build output #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 11, 2025
Merged

chore: don't require full build output #204

merged 2 commits into from
Mar 11, 2025

Conversation

@thymikee
Copy link
Contributor

@thymikee thymikee commented Mar 11, 2025

Summary

I think there's no need to parse whole build output from xcodebuild since we're looking for the PLATFORM_NAME only to pass to the -sdk flag.

Test plan

szymonrybczak
szymonrybczak approved these changes Mar 11, 2025
View reviewed changes
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good one

@thymikee thymikee merged commit a141247 into main Mar 11, 2025
2 checks passed
@thymikee thymikee deleted the chore/no-build-output branch March 11, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@szymonrybczak szymonrybczak szymonrybczak approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thymikee @szymonrybczak