Skip to content

fix: set missing root property to config #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: set missing root property to config #38

merged 1 commit into from
Dec 2, 2024

Conversation

@szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Dec 2, 2024 •
edited
Loading

Summary

The goal of importUp is to find config in parent directories, it works fine but it didn't pass the directory when the config was found in different directory than process.cwd() e.g. when someone runs rnef run:android from /android folder.

Before:

CleanShot 2024-12-02 at 13 20 44@2x

After:

CleanShot 2024-12-02 at 13 21 00@2x

Test plan

  1. Go to /android
  2. rnef run:android should run correctly.

@thymikee thymikee merged commit 58d81e3 into main Dec 2, 2024
1 check passed
@thymikee thymikee deleted the fix/add-missing-root-property-config branch December 2, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thymikee thymikee thymikee approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szymonrybczak @thymikee