feat: add run:ios command
#41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thymikee
force-pushed
the
feat/run-ios
branch
from
53e17b6 to
a8dba3e
Compare
packages/plugin-platform-apple/src/lib/commands/run/createRun.ts
Outdated
Show resolved
Hide resolved
| * - iPhone 11 | ||
| */ | ||
|
|
||
| const fallbackSimulators = [ |
There was a problem hiding this comment.
for me it rarely worked because the names are iPhone 14 (iOS version). maybe our fallback logic can just get the first simulators from the command's output?
Comment on lines
87
to
82
| const device = args.interactive | ||
| ? await promptForDeviceSelection(devices) | ||
| : args.udid | ||
| ? devices.find((d) => d.udid === args.udid) | ||
| : args.device | ||
| ? matchingDevice(devices, args.device) | ||
| : args.simulator | ||
| ? await matchingSimulator(devices, platformName, args.simulator, args.udid) | ||
| : undefined; |
thymikee
force-pushed
the
feat/run-ios
branch
from
a7fff98 to
9c8b83a
Compare
thymikee
force-pushed
the
feat/run-ios
branch
2 times, most recently
from
b9a03cf to
4b93420
Compare
thymikee
force-pushed
the
feat/run-ios
branch
from
4b93420 to
5bbd4a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Initial support for
run:ioscommand ported from RNC CLI. Changes compared to reference implementation:--terminal,--packager,--list-devicesflagsxcdevicecall todevicectlfor faster lookup--catalystflag for running apps in Mac Catalyst modeScreen.Recording.2024-12-09.at.14.07.58.mov
Test plan
Ported tests. Integration tests to be added in a separate PR