chore: nightly job #52
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thymikee @szymonrybczak pls take a look. |
mdjastrzebski
force-pushed
the
chore/nightly-ci
branch
from
782bafb to
a3b8b93
Compare
thymikee
reviewed
Dec 17, 2024
Comment on lines
+32
to
+36
| - name: Typecheck and lint | ||
| run: pnpm lint typecheck | ||
|
|
||
| - name: Run tests | ||
| run: pnpm test |
There was a problem hiding this comment.
I think there's no need to run typecheck or unit tests, for nightlies we're only interested in build, right?
There was a problem hiding this comment.
I've added this for extra safety. Normally we only run lint/typecheck/test only of affected packages (as nx decides), Here we are running it on all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Nightly job for RNEF that runs full validation (not only affected packages), as well as deployes the template and builds Android.
Test plan