feat: add remote cache provider setup to the create-app command #551
Conversation
🦋 Changeset detectedLatest commit: 6c67882 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
Last thing I have in mind before merging - info banners after picking up a provider and right before being prompted for args. We can put there what to expose with env variables (GITHUB_TOKEN, AWS_ACCESS_KEY etc) |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
| '}),', | ||
| ]); | ||
| } | ||
| } |
There was a problem hiding this comment.
Bug: Cache Config Template Errors
The remoteCacheProviderToConfigTemplate function has two issues. It may return undefined for unhandled provider values. Additionally, user input for arguments like owner or bucket is directly interpolated into the generated config, which can lead to invalid JavaScript syntax if inputs contain single quotes.
Summary
Part of #546
Closes #547
Test plan
create-appCLI and pick your provider of choice.Github Actions demo
gh-actions.mp4
S3 demo
s3.mp4