Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/brave-tires-poke.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'create-rock': patch
---

perf: drop package-json dep
1 change: 0 additions & 1 deletion packages/create-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@
"@rock-js/tools": "^0.10.2",
"gradient-string": "^3.0.0",
"minimist": "^1.2.8",
"package-json": "^10.0.1",
"tar": "^7.4.3",
"tslib": "^2.3.0"
},
Expand Down
37 changes: 30 additions & 7 deletions packages/create-app/src/lib/utils/tarball.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import fs from 'node:fs';
import path from 'node:path';
import { RockError } from '@rock-js/tools';
import packageJson from 'package-json';
import * as tar from 'tar';
import { getNameWithoutExtension } from './fs.js';

Expand All @@ -11,17 +10,17 @@ export async function downloadTarballFromNpm(
targetDir: string,
) {
try {
const metadata = await packageJson(packageName, { version });
const versionData = await getPackageVersionData(packageName, version);

const tarballUrl = metadata['dist']?.tarball;
const tarballUrl = versionData.dist?.tarball;
if (!tarballUrl) {
throw new RockError('Tarball URL not found.');
}

const response = await fetch(tarballUrl);
if (!response.ok) {
const tarballResponse = await fetch(tarballUrl);
if (!tarballResponse.ok) {
throw new RockError(
`Failed to fetch package ${packageName}: ${response.statusText}`,
`Failed to fetch package ${packageName}: ${tarballResponse.statusText}`,
);
}

Expand All @@ -30,7 +29,7 @@ export async function downloadTarballFromNpm(
`${packageName.replace('/', '-')}.tgz`,
);
// Write the tarball to disk
const arrayBuffer = await response.arrayBuffer();
const arrayBuffer = await tarballResponse.arrayBuffer();
fs.writeFileSync(tarballPath, new Uint8Array(arrayBuffer));

return tarballPath;
Expand All @@ -41,6 +40,30 @@ export async function downloadTarballFromNpm(
}
}

async function getPackageVersionData(packageName: string, version: string) {
// Fetch package metadata from npm registry
const registryUrl = `https://registry.npmjs.org/${packageName}`;
const response = await fetch(registryUrl);

if (!response.ok) {
throw new RockError(
`Failed to fetch package metadata for ${packageName}: ${response.statusText}`,
);
}

const metadata = await response.json();
const versionTag = metadata['dist-tags']?.[version];
const versionData = versionTag
? metadata.versions?.[versionTag]
: metadata.versions?.[version];
if (!versionData) {
throw new RockError(
`Version ${version} not found for package ${packageName}`,
);
}
return versionData;
}

/**
* Extracts a tarball to a temporary directory and returns the path to the extracted directory
* @param tarballPath - Path to the tarball to extract
Expand Down
106 changes: 0 additions & 106 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading