Skip to content

Conversation

@thymikee
Copy link
Contributor

Summary

  • move saving cache to buildApp (which better prepares Apple platform to handle build cache, still tied to "ios" though)
  • show that fingerprint was updated

Test plan

◇  Calculated project fingerprint: 4d761836e1315c588601b8fef1fd4ad95d3a78b0
│
◇  Installed Ruby Gems
│
◇  Installed CocoaPods dependencies successfully [9s]
│
◇  Updated project fingerprint: 4e3b89195e005e45c88e2734c6875d9264e0aa4a
│
◇  Build Settings:

@changeset-bot
Copy link

changeset-bot bot commented Sep 11, 2025

🦋 Changeset detected

Latest commit: bd66110

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@rock-js/platform-apple-helpers Patch
@rock-js/tools Patch
@rock-js/config Patch
@rock-js/platform-android Patch
@rock-js/platform-ios Patch
@rock-js/plugin-brownfield-android Patch
@rock-js/plugin-brownfield-ios Patch
@rock-js/plugin-metro Patch
@rock-js/plugin-repack Patch
@rock-js/provider-github Patch
@rock-js/provider-s3 Patch
@rock-js/test-helpers Patch
@rock-js/welcome-screen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 11, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rock Ignored Ignored Preview Sep 11, 2025 0:56am

buildFolder: args.buildFolder,
});

saveLocalBuildCache(artifactNameToSave, buildSettings.appPath);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

silly question: but why we don't have any checks here for remote cache, but always saving?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we're saving local cache after successful build, so you don't need remote cache to have local one

Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@thymikee thymikee merged commit 4f8c7dc into main Sep 12, 2025
5 checks passed
@thymikee thymikee deleted the refactor/saving-cache-ios branch September 12, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants