Skip to content

fix: expose reactNativePath for Re.Pack getDevMiddleware #582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 24, 2025
Merged

fix: expose reactNativePath for Re.Pack getDevMiddleware #582

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1093cb2
fix: expose reactNativePath for Re.Pack getDevMiddleware
tomhendra Sep 23, 2025
83f0634
chore: add changeset
tomhendra Sep 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/ninety-apples-retire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@rock-js/plugin-repack': patch
---

Expose reactNativePath in pluginRepack.ts to prevent undefined error in Re.Pack getDevMiddleware when starting up dev server
3 changes: 2 additions & 1 deletion packages/plugin-repack/src/lib/pluginRepack.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export const pluginRepack =
name: 'start',
description: 'Starts Re.Pack dev server.',
action: async (args: StartArgs) => {
const reactNativePath = api.getReactNativePath();
const root = api.getProjectRoot();
const platforms = api.getPlatforms();
const { port, startDevServer } = await findDevServerPort(
Expand All @@ -54,7 +55,7 @@ export const pluginRepack =
startCommand.func(
[],
// @ts-expect-error TODO fix getPlatforms type
{ root, platforms, ...pluginConfig },
{ reactNativePath, root, platforms, ...pluginConfig },
{ ...args, port },
);
},
Expand Down
Loading