Skip to content

Conversation

@thymikee
Copy link
Contributor

@thymikee thymikee commented Sep 29, 2025

Summary

Previous implementation only took env keys into a hash, so changing the env wouldn't affect the fingerprint. This PR changes it in a way that the env information is now recorded as an object of keys and values:

{
      "type": "json",
      "key": "json:env",
      "hash": "8488bb5c4dea64136b0047436ee14d7f8d45b919",
      "json": {
        "ABC": "[HASHED:ba7816bf]",
        "S3_ACCESS_KEY_ID": "[HASHED:512aa3ca]",
        "S3_SECRET_ACCESS_KEY": "[HASHED:12fad43b]"
      }
    },

To make it safe when debugging on CI, we're now also hashing the values

Test plan

@changeset-bot
Copy link

changeset-bot bot commented Sep 29, 2025

🦋 Changeset detected

Latest commit: 83ad9a1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 14 packages
Name Type
@rock-js/tools Patch
rock Patch
@rock-js/config Patch
@rock-js/platform-android Patch
@rock-js/platform-apple-helpers Patch
@rock-js/platform-ios Patch
@rock-js/plugin-brownfield-android Patch
@rock-js/plugin-brownfield-ios Patch
@rock-js/plugin-metro Patch
@rock-js/plugin-repack Patch
@rock-js/provider-github Patch
@rock-js/provider-s3 Patch
@rock-js/test-helpers Patch
@rock-js/welcome-screen Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 29, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Preview Comments Updated (UTC)
rock Ignored Ignored Sep 29, 2025 5:42pm

@thymikee thymikee merged commit c904ec9 into main Sep 29, 2025
5 checks passed
@thymikee thymikee deleted the fix/sensitive-env branch September 29, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants