fix: run:ios with non-app targets ordered first #596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 75a2630 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When the iOS project's scheme has non-app target included and it's ordered as first on the list, our current logic would fail and make you use
--targetflag to fix it.What we can do, however, is filtering for app or framework (for brownfield case) WRAPPER_EXTENSION first, and avoid processing unrelated targets (which we had some logic before for "React" or "React-Core" included in older RN versions).
Ported from react-native-community/cli#2707
Also sneaked in better error messages for when Cocoapods fail
Test plan
Add a static library target, convert it to a group (for CocoaPods) and update scheme to list it first
run:iosworkspackage:iosworks