Merge pull request open5e#780 from open5e/709-revisit-object-stats-for-size-immunities-ac-and-hp

709 revisit object stats for size immunities ac and hp

Author: augustjohnson

api_v2/serializers/item.py

@@ -79,7 +79,7 @@ def get_distance_unit(self, Weapon):
         return Weapon.get_distance_unit
 
     def get_properties(self, instance):
-        properties = instance.properties.all().order_by('-property_id')
+        properties = instance.properties.all().order_by("pk")
         return WeaponPropertyAssignmentSerializer(properties, context={'request': None}, many=True).data
 
 class WeaponSummarySerializer(GameContentSerializer):
@@ -139,7 +139,7 @@ class ItemSerializer(GameContentSerializer):
     document = DocumentSummarySerializer()
     category = ItemCategorySummarySerializer()
     rarity = ItemRaritySerializer()
-    damage_immunities = DamageTypeSummarySerializer(many=True)
+    #damage_immunities = DamageTypeSummarySerializer(many=True)
     size = SizeSummarySerializer()
     weight_unit = serializers.SerializerMethodField()
 
@@ -149,7 +149,23 @@ def get_weight_unit(self, item):
 
     class Meta:
         model = models.Item
-        fields = '__all__'
+        fields = [
+            'url',
+            'key',
+            'name',
+            'desc',
+            'category',
+            'rarity',
+            'is_magic_item',
+            'weapon',
+            'armor',
+            'size',
+            'weight',
+            'weight_unit',
+            'cost',
+            'requires_attunement',
+            'document',]
+
 
 class ItemSummarySerializer(GameContentSerializer):
     class Meta:

api_v2/tests/responses/TestObjects.test_item_armor_example.approved.json

@@ -11,28 +11,12 @@
         "strength_score_required": 15,
         "url": "http://localhost:8000/v2/armor/srd_splint/"
     },
-    "armor_class": 0,
-    "armor_detail": "",
     "category": {
         "key": "armor",
         "name": "Armor",
         "url": "http://localhost:8000/v2/itemcategories/armor/"
     },
     "cost": "200.00",
-    "damage_immunities": [
-        {
-            "key": "poison",
-            "name": "Poison",
-            "url": "http://localhost:8000/v2/damagetypes/poison/"
-        },
-        {
-            "key": "psychic",
-            "name": "Psychic",
-            "url": "http://localhost:8000/v2/damagetypes/psychic/"
-        }
-    ],
-    "damage_resistances": [],
-    "damage_vulnerabilities": [],
     "desc": "This armor is made of narrow vertical strips of metal riveted to a backing of leather that is worn over cloth padding. Flexible chain mail protects the joints.",
     "document": {
         "display_name": "5e 2014 Rules",
@@ -50,13 +34,9 @@
             "url": "http://localhost:8000/v2/publishers/wizards-of-the-coast/"
         }
     },
-    "hit_dice": null,
-    "hit_points": 0,
     "is_magic_item": false,
     "key": "srd_splint-armor",
     "name": "Splint Armor",
-    "nonmagical_attack_immunity": false,
-    "nonmagical_attack_resistance": false,
     "rarity": null,
     "requires_attunement": false,
     "size": {

api_v2/tests/responses/TestObjects.test_item_example.approved.json

@@ -1,27 +1,11 @@
 {
     "armor": null,
-    "armor_class": 0,
-    "armor_detail": "",
     "category": {
         "key": "wondrous-item",
         "name": "Wondrous Item",
         "url": "http://localhost:8000/v2/itemcategories/wondrous-item/"
     },
     "cost": "0.00",
-    "damage_immunities": [
-        {
-            "key": "poison",
-            "name": "Poison",
-            "url": "http://localhost:8000/v2/damagetypes/poison/"
-        },
-        {
-            "key": "psychic",
-            "name": "Psychic",
-            "url": "http://localhost:8000/v2/damagetypes/psychic/"
-        }
-    ],
-    "damage_resistances": [],
-    "damage_vulnerabilities": [],
     "desc": "This item first appears to be a Large sealed iron barrel weighing 500 pounds. The barrel has a hidden catch, which can be found with a successful DC 20 Intelligence (Investigation) check. Releasing the catch unlocks a hatch at one end of the barrel, allowing two Medium or smaller creatures to crawl inside. Ten levers are set in a row at the far end, each in a neutral position, able to move either up or down. When certain levers are used, the apparatus transforms to resemble a giant lobster.\r\n\r\nThe apparatus of the Crab is a Large object with the following statistics:\r\n\r\n**Armor Class:** 20\r\n\r\n**Hit Points:** 200\r\n\r\n**Speed:** 30 ft., swim 30 ft. (or 0 ft. for both if the legs and tail aren't extended)\r\n\r\n**Damage Immunities:** poison, psychic\r\n\r\nTo be used as a vehicle, the apparatus requires one pilot. While the apparatus's hatch is closed, the compartment is airtight and watertight. The compartment holds enough air for 10 hours of breathing, divided by the number of breathing creatures inside.\r\n\r\nThe apparatus floats on water. It can also go underwater to a depth of 900 feet. Below that, the vehicle takes 2d6 bludgeoning damage per minute from pressure.\r\n\r\nA creature in the compartment can use an action to move as many as two of the apparatus's levers up or down. After each use, a lever goes back to its neutral position. Each lever, from left to right, functions as shown in the Apparatus of the Crab Levers table.\r\n\r\n**Apparatus of the Crab Levers (table)**\r\n\r\n| Lever | Up                                                                                                                               | Down                                                                                                                                        |\r\n|-------|----------------------------------------------------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------|\r\n| 1     | Legs and tail extend, allowing the apparatus to walk and swim.                                                                   | Legs and tail retract, reducing the apparatus's speed to 0 and making it unable to benefit from bonuses to speed.                           |\r\n| 2     | Forward window shutter opens.                                                                                                    | Forward window shutter closes.                                                                                                              |\r\n| 3     | Side window shutters open (two per side).                                                                                        | Side window shutters close (two per side).                                                                                                  |\r\n| 4     | Two claws extend from the front sides of the apparatus.                                                                          | The claws retract.                                                                                                                          |\r\n| 5     | Each extended claw makes the following melee weapon attack: +8 to hit, reach 5 ft., one target. Hit: 7 (2d6) bludgeoning damage. | Each extended claw makes the following melee weapon attack: +8 to hit, reach 5 ft., one target. Hit: The target is grappled (escape DC 15). |\r\n| 6     | The apparatus walks or swims forward.                                                                                            | The apparatus walks or swims backward.                                                                                                      |\r\n| 7     | The apparatus turns 90 degrees left.                                                                                             | The apparatus turns 90 degrees right.                                                                                                       |\r\n| 8     | Eyelike fixtures emit bright light in a 30-foot radius and dim light for an additional 30 feet.                                  | The light turns off.                                                                                                                        |\r\n| 9     | The apparatus sinks as much as 20 feet in liquid.                                                                                | The apparatus rises up to 20 feet in liquid.                                                                                                |\r\n| 10    | The rear hatch unseals and opens.                                                                                                | The rear hatch closes and seals.                                                                                                            |",
     "document": {
         "display_name": "5e 2014 Rules",
@@ -39,13 +23,9 @@
             "url": "http://localhost:8000/v2/publishers/wizards-of-the-coast/"
         }
     },
-    "hit_dice": null,
-    "hit_points": 0,
     "is_magic_item": true,
     "key": "srd_apparatus-of-the-crab",
     "name": "Apparatus of the Crab",
-    "nonmagical_attack_immunity": false,
-    "nonmagical_attack_resistance": false,
     "rarity": {
         "key": "legendary",
         "name": "Legendary",

api_v2/tests/responses/TestObjects.test_item_melee_weapon_example.approved.json

@@ -1,27 +1,11 @@
 {
     "armor": null,
-    "armor_class": 0,
-    "armor_detail": "",
     "category": {
         "key": "weapon",
         "name": "Weapon",
         "url": "http://localhost:8000/v2/itemcategories/weapon/"
     },
     "cost": "10.00",
-    "damage_immunities": [
-        {
-            "key": "poison",
-            "name": "Poison",
-            "url": "http://localhost:8000/v2/damagetypes/poison/"
-        },
-        {
-            "key": "psychic",
-            "name": "Psychic",
-            "url": "http://localhost:8000/v2/damagetypes/psychic/"
-        }
-    ],
-    "damage_resistances": [],
-    "damage_vulnerabilities": [],
     "desc": "A short sword.",
     "document": {
         "display_name": "5e 2014 Rules",
@@ -39,13 +23,9 @@
             "url": "http://localhost:8000/v2/publishers/wizards-of-the-coast/"
         }
     },
-    "hit_dice": null,
-    "hit_points": 0,
     "is_magic_item": false,
     "key": "srd_shortsword",
     "name": "Shortsword",
-    "nonmagical_attack_immunity": false,
-    "nonmagical_attack_resistance": false,
     "rarity": null,
     "requires_attunement": false,
     "size": {

api_v2/tests/responses/TestObjects.test_item_ranged_weapon_example.approved.json

@@ -1,27 +1,11 @@
 {
     "armor": null,
-    "armor_class": 0,
-    "armor_detail": "",
     "category": {
         "key": "weapon",
         "name": "Weapon",
         "url": "http://localhost:8000/v2/itemcategories/weapon/"
     },
     "cost": "50.00",
-    "damage_immunities": [
-        {
-            "key": "poison",
-            "name": "Poison",
-            "url": "http://localhost:8000/v2/damagetypes/poison/"
-        },
-        {
-            "key": "psychic",
-            "name": "Psychic",
-            "url": "http://localhost:8000/v2/damagetypes/psychic/"
-        }
-    ],
-    "damage_resistances": [],
-    "damage_vulnerabilities": [],
     "desc": "A longbow.",
     "document": {
         "display_name": "5e 2014 Rules",
@@ -39,13 +23,9 @@
             "url": "http://localhost:8000/v2/publishers/wizards-of-the-coast/"
         }
     },
-    "hit_dice": null,
-    "hit_points": 0,
     "is_magic_item": false,
     "key": "srd_longbow",
     "name": "Longbow",
-    "nonmagical_attack_immunity": false,
-    "nonmagical_attack_resistance": false,
     "rarity": null,
     "requires_attunement": false,
     "size": {
@@ -69,19 +49,19 @@
         "name": "Longbow",
         "properties": [
             {
-                "detail": null,
+                "detail": "range 150/600",
                 "property": {
-                    "name": "Two-Handed",
+                    "name": "Ammunition",
                     "type": null,
-                    "url": "http://localhost:8000/v2/weaponproperties/srd-2014_two-handed-wp/"
+                    "url": "http://localhost:8000/v2/weaponproperties/srd-2014_ammunition-wp/"
                 }
             },
             {
-                "detail": "range 150/600",
+                "detail": null,
                 "property": {
-                    "name": "Ammunition",
+                    "name": "Two-Handed",
                     "type": null,
-                    "url": "http://localhost:8000/v2/weaponproperties/srd-2014_ammunition-wp/"
+                    "url": "http://localhost:8000/v2/weaponproperties/srd-2014_two-handed-wp/"
                 }
             }
         ],

api_v2/tests/responses/TestObjects.test_weapon_example.approved.json

@@ -31,17 +31,17 @@
         {
             "detail": null,
             "property": {
-                "name": "Light",
+                "name": "Finesse",
                 "type": null,
-                "url": "/v2/weaponproperties/srd-2014_light-wp/"
+                "url": "/v2/weaponproperties/srd-2014_finesse-wp/"
             }
         },
         {
             "detail": null,
             "property": {
-                "name": "Finesse",
+                "name": "Light",
                 "type": null,
-                "url": "/v2/weaponproperties/srd-2014_finesse-wp/"
+                "url": "/v2/weaponproperties/srd-2014_light-wp/"
             }
         }
     ],

api_v2/tests/responses/TestObjects.test_weapon_with_mastery_example.approved.json

@@ -28,21 +28,21 @@
     "long_range": 0.0,
     "name": "Longsword",
     "properties": [
-        {
-            "detail": "1d10",
-            "property": {
-                "name": "Versatile",
-                "type": null,
-                "url": "/v2/weaponproperties/srd-2024_versatile-wp/"
-            }
-        },
         {
             "detail": null,
             "property": {
                 "name": "Sap",
                 "type": "Mastery",
                 "url": "/v2/weaponproperties/srd-2024_sap-mastery/"
             }
+        },
+        {
+            "detail": "1d10",
+            "property": {
+                "name": "Versatile",
+                "type": null,
+                "url": "/v2/weaponproperties/srd-2024_versatile-wp/"
+            }
         }
     ],
     "range": 0.0,