Build from git

[jvulgan]

Summary by Sourcery

Add support for building packages from git-based sdists and document the new configuration field.

New Features:

• Allow onboarded packages to specify a git-based source distribution URL that is used instead of PyPI when identifying build artifacts.
• Onboard the griffe package using the new git-based source configuration.

Documentation:

• Document the optional sdist_url field in onboarded package metadata and how it influences package identification.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds support for building onboarded packages directly from git-sourced sdists by extending the package metadata schema and updating identify-packages to emit PEP 440 URL requirements, and onboards the griffe package using this mechanism.

Flow diagram for git-sourced sdist handling in identify-packages

flowchart LR
    A[onboarded_packages JSON
    fields: name, version, ignored_versions, build_extra, sdist_url] --> B[identify-packages]

    B --> C{sdist_url present?}
    C -- Yes --> D[Emit PEP 440 URL requirement
    pkg @ sdist_url@version]
    C -- No --> E[Emit standard requirement
    pkg==version]

    D --> F[Build pipeline
    fetch from git URL]
    E --> F

    G[griffe.json
    uses sdist_url git URL] --> B

Loading

File-Level Changes

Change	Details	Files
Extend onboarded package metadata to support git-based sdist sources and wire this through identify-packages.	Document new optional sdist_url field in CLAUDE.md, describing its purpose and expected git URL format. Update identify-packages script to read sdist_url from onboarded package JSONs when present. Modify requirement generation logic to emit PEP 440 URL requirements of the form pkg @ url@version when sdist_url is set instead of using the default PyPI source.	CLAUDE.md hack/identify-packages
Onboard the griffe package using the new git-based build mechanism.	Add onboarded_packages/griffe.json describing griffe’s version and git-based sdist source. Ensure griffe’s metadata conforms to the extended schema including optional sdist_url.	onboarded_packages/griffe.json

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• The description of sdist_url in CLAUDE.md could briefly clarify how the @version portion of the generated PEP 440 requirement is derived (e.g., tag vs. commit hash) and what happens if the git URL already contains a ref.
• In identify-packages, consider validating sdist_url values more strictly (e.g., ensure they are git URLs and produce clear errors for malformed inputs) before constructing the PEP 440 URL requirement.
• It may be helpful for future maintainers if identify-packages logs or annotates when a package is being resolved from sdist_url rather than PyPI, so the source of truth is obvious during debugging.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- The description of `sdist_url` in CLAUDE.md could briefly clarify how the `@version` portion of the generated PEP 440 requirement is derived (e.g., tag vs. commit hash) and what happens if the git URL already contains a ref.
- In `identify-packages`, consider validating `sdist_url` values more strictly (e.g., ensure they are git URLs and produce clear errors for malformed inputs) before constructing the PEP 440 URL requirement.
- It may be helpful for future maintainers if `identify-packages` logs or annotates when a package is being resolved from `sdist_url` rather than PyPI, so the source of truth is obvious during debugging.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[jvulgan]

@calungaproject/developers ptal. notice girffe built successfully when building directly from git as opposed to failing with the wrong symlinks in #4213 and #1741 (and other packages which tried to build it as dep)