[fud2] Add consistent parameter to correctly emulate or execute on Xilinx. #2400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also guarantee that the hw_emu/sw_emu/hw environment variable is set correctly
|
This pull request has not seen activity in 14 days and is being marked as stale. If you're continuing work on this, please reply and state how to get this PR in a mergeable state or what issues it is blocked on. If the PR is not ready for review, please mark it as a draft. The PR will be closed in 7 days if there is no further activity. |
|
This stale PR is being closed because it has not seen any activity in 7 days. If you're planning to continue work on it, please reopen it and mention how to make progress on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More small parts of #2267. This should fix treatment of the
XCL_EMULATION_MODEenvironment variable, with respect tohwandhw_emuvalues (aka execution and emulation).Currently
fud2does not allow forsw_emuvalues because software emulation requires C files, not something we've really been dealing with.From some spot checking on havarti seems like
hw_emucan compile to anxclbinfine, but targeting actual execution seems to fail? At least on my toydyn-mem-vec-add.futilfile.Also finally wrote down the explicit steps to use (and the parameters required at each step) and added them to the docs.
I'll move them and polish them up if needed.
To ease dealing with parameters would it make sense to require the
[xilinx]parameters to be part of thefud2config file? That way most of the logic between runs would be consistent, independent of the user remembering what they compiled to originally.