Allow multiple library paths #2436
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachitnigam
reviewed
Mar 28, 2025
| )] | ||
| pub lib_path: PathBuf, | ||
| #[argh(option, short = 'l')] | ||
| pub lib_path: Vec<PathBuf>, |
There was a problem hiding this comment.
this will break existing "cargo install calyx" users. Please add back the default repo.
rachitnigam
reviewed
Mar 28, 2025
src/main.rs
Outdated
| @@ -55,6 +55,9 @@ fn main() -> PassResult<()> { | |||
| } | |||
| } | |||
|
|
|||
| opts.lib_path | |||
| .push(option_env!("CALYX_PRIMITIVES_DIR").unwrap_or(".").into()); | |||
There was a problem hiding this comment.
This will always add the primitives dir to the lib path which is not the behavior of the existing set up.
rachitnigam
requested changes
Mar 28, 2025
|
I've changed it so that it emits an error if it finds an import in multiple library paths. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it possible to specify multiple library paths, which is useful for frontends that wish to provide their own primitive libraries in addition to Calyx's standard library.