feat: timeout for interpreter module #1851
Conversation
Wendong-Fan
left a comment
Wendong-Fan
left a comment
There was a problem hiding this comment.
thanks @lqjack 's contribution and sorry for the late review, could you also helping update the docstring? Thanks in advance!
| require_confirm: bool = True, | ||
| print_stdout: bool = False, | ||
| print_stderr: bool = True, | ||
| default_timeout: int = 60, |
There was a problem hiding this comment.
should we also update the docstring?
|
|
||
| @abstractmethod | ||
| def run(self, code: str, code_type: str) -> str: | ||
| def run(self, code: str, code_type: str, timeout: int = None) -> str: |
There was a problem hiding this comment.
we also need to update the docstring
Wendong-Fan
changed the title
| self, | ||
| file: Path, | ||
| code_type: str, | ||
| timeout: int = None |
There was a problem hiding this comment.
prefer Optional[int] in the type hints for clarity.
| self.default_timeout = default_timeout | ||
|
|
||
| def run(self, code: str, code_type: str) -> str: | ||
| def run(self, code: str, code_type: str, timeout:int =None) -> str: |
There was a problem hiding this comment.
prefer Optional[int] in the type hints for clarity.
| self, | ||
| code: str, | ||
| code_type: str, | ||
| timeout: int = None, |
There was a problem hiding this comment.
prefer Optional[int] in the type hints for clarity.
| self, | ||
| file: Path, | ||
| code_type: str, | ||
| timeout: int = None, |
There was a problem hiding this comment.
prefer Optional[int] in the type hints for clarity.
|
|
||
| @abstractmethod | ||
| def run(self, code: str, code_type: str) -> str: | ||
| def run(self, code: str, code_type: str, timeout: int = None) -> str: |
There was a problem hiding this comment.
prefer Optional[int] in the type hints for clarity.
|
|
||
| @abstractmethod | ||
| def run(self, code: str, code_type: str) -> str: | ||
| def run(self, code: str, code_type: str, timeout: int = None) -> str: |
There was a problem hiding this comment.
You need to update the argument timeout: Optional[int] = None in the def run of all of the subclasses if you are updating this parameter in the base class. You have not updated it in e2b_interpreter.py and subprocess_interpreter.py
3 participants
Description
add timeout support for interpreter module
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!